-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connect kwarg to Pool to better support GCP's CloudSQL #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1manson
changed the title
Add connect_fn kwarg to pool to better support GCP's CloudSQL
Add connect_fn kwarg to Pool to better support GCP's CloudSQL
Aug 5, 2024
elprans
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I made some tweaks, mainly renamed connect_fn
to connect
for consistency with other Pool callbacks.
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
Merged
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 18, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
Merged
elprans
added a commit
that referenced
this pull request
Oct 19, 2024
Support Python 3.13 and PostgreSQL 17. Improvements ============ * Implement GSSAPI authentication (by @eltoder in 1d4e568 for #1122) * Implement SSPI authentication (by @eltoder in 1aab209 for #1128) * Add initial typings (by @bryanforbes in d42432b for #1127) * Allow building with Cython 3 (by @musicinmybrain in 258d8a9 for #1101) * docs: fix connection pool close call (#1125) (by @paulovitorweb in e848814 for #1125) * Add support for the `sslnegotiation` parameter (by @elprans in afdb05c for #1187) * Test and build on Python 3.13 (by @elprans in 3aa9894 for #1188) * Support PostgreSQL 17 (by @elprans in cee97e1 for #1189) (by @MeggyCal in aa2d0e6 for #1185) * Add `fetchmany` to execute many *and* return rows (by @rossmacarthur in 73f2209 for #1175) * Add `connect` kwarg to Pool to better support GCP's CloudSQL (by @d1manson in 3ee19ba for #1170) * Allow customizing connection state reset (#1191) (by @elprans in f6ec755 for #1191) Fixes ===== * s/quote/quote_plus/ in the note about DSN part quoting (by @elprans in 1194a8a for #1151) * Use asyncio.run() instead of run_until_complete() (by @eltoder in 9fcddfc for #1140) * Require async_timeout for python < 3.11 (#1177) (by @Pliner in 327f2a7 for #1177) * Allow testing with uvloop on Python 3.12 (#1182) (by @musicinmybrain in 597fe54 for #1182) * Mark pool-wrapped connection coroutine methods as coroutines (by @elprans in 636420b for #1134) * handle `None` parameters in `copy_from_query`, returning `NULL` (by @fobispotc in 259d16e for #1180) * fix: return the pool from _async_init__ if it's already initialized (#1104) (by @guacs in 7dc5872 for #1104) * Replace obsolete, unsafe `Py_TRASHCAN_SAFE_BEGIN/END` (#1150) (by @musicinmybrain in 11101c6 for #1150)
Merged
d1manson
changed the title
Add connect_fn kwarg to Pool to better support GCP's CloudSQL
Add connect kwarg to Pool to better support GCP's CloudSQL
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to an issue I created a few months back and then updated last week.
GCP's cloud-sql-python-connector offers asyncpg as one of its drivers - see logic here - however that can only be used as a single connection, not in conjunction with asyncpg's
Pool
class because it wraps theconnection.connect(..)
call in various bits of logic to do with authentication and SSL (which I admit I haven't tried to fully understand).This PR simply turns the call to
connection.connect
into a kwarg parameter on the Pool class so it can be overridden.Usage would be something like this:
Note the gcp repo's docs suggest using SQLAlchemy for a pool, but that's not much use if your codebase already uses asyncpg's Pool API (at least as far as I understand from SQLAlchemy).
--
Couple of additional thoughts:
It is perhaps a bit confusing that there will now be three functions that all see somewhat similar in name -
init
,setup
and aconnect_fn
, but I don't know enough to say if they can be refactored into fewer kwargs somehow.As noted in my issue, linked above, it is possible to work around this by subclassing the Pool class, but that's not especially nice and this seemed like a small ask so thought it was worth suggesting.