-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metro popover support #1603
Open
charlesw
wants to merge
11
commits into
MahApps:develop
Choose a base branch
from
charlesw:master
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Metro popover support #1603
+732
−170
Commits on Oct 18, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 1dbd77c - Browse repository at this point
Copy the full SHA 1dbd77cView commit details
Commits on Oct 23, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 07e7aa7 - Browse repository at this point
Copy the full SHA 07e7aa7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41d682e - Browse repository at this point
Copy the full SHA 41d682eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 272bd6c - Browse repository at this point
Copy the full SHA 272bd6cView commit details
Commits on Oct 24, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 2f6946d - Browse repository at this point
Copy the full SHA 2f6946dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f67ef91 - Browse repository at this point
Copy the full SHA f67ef91View commit details -
Fixed popup event handling bug
Previously the owning window's PreviewMouseDown event, used to auto close the popover, was being subscribed to on the popover's load event and unsubscribed on unload however this didn't take into account that the Load could be called multiple times. The popover now keeps track of if it's subscribe to the given event using a disposable handler, which is also used to unsubscribe.
Configuration menu - View commit details
-
Copy full SHA for b17f5ee - Browse repository at this point
Copy the full SHA b17f5eeView commit details -
* Background and Foreground colors are now dynamically applied using the WhiteBrush and BlackBrush respectively. * MetroPopover doesn't partake in layout (Visibility is always Collapsed). * Popover adorner is only attached when open.
Configuration menu - View commit details
-
Copy full SHA for 5e292f7 - Browse repository at this point
Copy the full SHA 5e292f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fbfd9e - Browse repository at this point
Copy the full SHA 0fbfd9eView commit details
Commits on Oct 25, 2014
-
Turned out that the popover needed a logical tree like this: MetroPopover -> MetroPopoverWindow -> Popover content This is presumably because WPF uses the logical tree, rather than visual tree when refreshing Dynamic Resources.
Configuration menu - View commit details
-
Copy full SHA for d6e17af - Browse repository at this point
Copy the full SHA d6e17afView commit details
Commits on Oct 26, 2014
-
Fixed autoclose no longer closes popover on selecting Combo Box item.
Previously clicking a dropdown item would cause the containing popover to close if it's AutoClose is set to True (default). This occured because the combobox uses a popup to display the dropdown which is outside the popovers visual tree which meant the popover thought that the user had clicked elsewhere in the window. This is fixed by using DependancyObject.GetParentObject() which falls back to the logical tree when required.
Configuration menu - View commit details
-
Copy full SHA for ab76211 - Browse repository at this point
Copy the full SHA ab76211View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.