drop unsupported_reason_add and supports_event? #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
unsupports_supports
branch
from
96d51cd to
ccbe5eb
Compare
|
update:
update:
|
kbrock
force-pushed
the
unsupports_supports
branch
2 times, most recently
from
aa2d119 to
ee4b53a
Compare
|
update:
|
kbrock
force-pushed
the
unsupports_supports
branch
from
ee4b53a to
137c279
Compare
|
Checked commits kbrock/manageiq-providers-openstack@b2440ed~...137c279 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
agrare
approved these changes
Feb 29, 2024
23 tasks
kbrock
commented
Mar 1, 2024
Comment on lines
+12
to
+18
| supports :events do | ||
| if parent_manager | ||
| parent_manager.unsupported_reason(:events) | ||
| else | ||
| _('no parent_manager to ems') | ||
| end | ||
| end |
There was a problem hiding this comment.
This is a change.
before, if there is no parent_manager, then it will be good
after: if there is no parent manager, then it will bad
sound right to you?
(I obviously think so, but wanted to make this change clear)
There was a problem hiding this comment.
Yeah, I don't think this manager could possibly work without a parent ems due to the delegated authentication so even allow_nil below probably doesn't make sense so I'm good with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unsupported_reason_add. Returning the string insteadsupports_events?part of: