Automate Simulation Conversion Form from HAML to React

[liu-samuel]

Automation / Embedded Automate / Simulation

Converting the Automate Simulation Form from HAML to React and connecting the simulation tree summary to the form.

Old:

New:

[jeffibm]

When we change the Type drop down, we get an error. could you check this please -

[jeffibm]

Could you make the title look the same if possible, like making them the same font size.

[jeffibm]

There is a failing test case under the GitHub actions/spec:routes. Could you please have a look at it..

[liu-samuel]

Could you make the title look the same if possible, like making them the same font size.

Do you mean the "Simulation" text? I can't really see a difference between the old and new version

[GilbertCherrie]

Leaving this as a reference for later.

To do:

• Figure out what to do with the copy button (either remove the button or change the way it works)
• Add the ability for the form to pre load values that were previously selected

[miq-bot]

Checked commits liu-samuel/manageiq-ui-classic@bf9e80f~...81df64b with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
8 files checked, 37 offenses detected

app/controllers/miq_ae_tools_controller.rb

• ⚠️ - Line 351, Col 63 - Lint/UnusedBlockArgument - Unused block argument - i. You can omit the argument if you don't care about it.
• ⚠️ - Line 352, Col 65 - Lint/ShadowingOuterLocalVariable - Shadowing outer local variable - i.
• ⚠️ - Line 493, Col 5 - Lint/Debugger - Remove debugger entry point byebug.
• ❗ - Line 336, Col 7 - Naming/AccessorMethodName - Do not prefix reader method names with get_.
• ❗ - Line 353, Col 14 - Style/StringConcatenation - Prefer string interpolation to string concatenation.
• ❗ - Line 354, Col 14 - Style/StringConcatenation - Prefer string interpolation to string concatenation.
• ❗ - Line 364, Col 7 - Naming/AccessorMethodName - Do not prefix reader method names with get_.

app/views/layouts/_ae_resolve_options.html.haml

• ⚠️ - Line 16 - Line is too long. [88/80]
• ⚠️ - Line 18 - Lint/DuplicateHashKey: Duplicated key in hash literal.
• ⚠️ - Line 1 - 6 consecutive Ruby scripts can be merged into a single :ruby filter
• ⚠️ - Line 7 - Avoid using instance variables in partials views

app/views/layouts/_content.html.haml

• 💣 💥 🔥 🚒 - Line 15 - Do not repeat id "#left_div" on the page
• 💣 💥 🔥 🚒 - Line 16 - Do not repeat id "#default_left_cell" on the page
• 💣 💥 🔥 🚒 - Line 19 - Do not repeat id "#left_div" on the page
• 💣 💥 🔥 🚒 - Line 20 - Do not repeat id "#default_left_cell" on the page
• ⚠️ - Line 15 - Classes should be listed before IDs (.sidebar-pf should precede #left_div)
• ⚠️ - Line 15 - id attribute must be in lisp-case
• ⚠️ - Line 26 - Hash attribute should end with one space before the closing brace or be on its own line
• ⚠️ - Line 26 - Hash attribute should start with one space after the opening brace
• ⚠️ - Line 26 - Line is too long. [153/80]
• ⚠️ - Line 27 - Classes should be listed before IDs (.row should precede #main-content)
• ⚠️ - Line 31 - id attribute must be in lisp-case
• ⚠️ - Line 32 - id attribute must be in lisp-case
• ⚠️ - Line 34 - Line is too long. [110/80]
• ⚠️ - Line 35 - Do not use inline style attributes
• ⚠️ - Line 35 - Hash attribute should end with one space before the closing brace or be on its own line
• ⚠️ - Line 35 - Hash attribute should start with one space after the opening brace
• ⚠️ - Line 35 - id attribute must be in lisp-case
• ⚠️ - Line 43 - Line is too long. [90/80]
• ⚠️ - Line 44 - Line is too long. [89/80]
• ⚠️ - Line 54 - Do not use inline style attributes
• ⚠️ - Line 54 - Hash attribute should end with one space before the closing brace or be on its own line
• ⚠️ - Line 54 - Hash attribute should start with one space after the opening brace
• ⚠️ - Line 54 - Line is too long. [82/80]
• ⚠️ - Line 54 - id attribute must be in lisp-case
• ⚠️ - Line 56 - Avoid using instance variables in partials views
• ⚠️ - Line 56 - Line is too long. [107/80]