Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a generic EvmSpecHelper.add_role #22959

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Mar 27, 2024

Make the EvmSpecHelper.assign_embedded_ansible_role more generic by taking a role_name argument allowing for other role types to be assigned.

@miq-bot
Copy link
Member

miq-bot commented Mar 27, 2024

Checked commit agrare@84bcda2 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy Fryguy merged commit 99d8125 into ManageIQ:master Mar 27, 2024
8 checks passed
@agrare agrare deleted the make_evm_spec_helper_assign_role_more_generic branch March 27, 2024 17:34
@Fryguy
Copy link
Member

Fryguy commented Mar 27, 2024

Backported to radjabov in commit 7bb6c9e.

commit 7bb6c9e007a35dafc9d8115f2630d1f020b3e804
Author: Jason Frey <[email protected]>
Date:   Wed Mar 27 13:34:35 2024 -0400

    Merge pull request #22959 from agrare/make_evm_spec_helper_assign_role_more_generic
    
    Add a generic EvmSpecHelper.add_role
    
    (cherry picked from commit 99d8125e49ac801e7b190e720d5c2f764e339408)

Fryguy added a commit that referenced this pull request Mar 27, 2024
…e_more_generic

Add a generic EvmSpecHelper.add_role

(cherry picked from commit 99d8125)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants