Remove calls to supports and supports back to back #23077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
This condenses the logic and avoids calling supports and unsupports for the same key
Use a variable to avoid calling supports and unsupported reason on the same code
kbrock
force-pushed
the
supports_unsupports-drop_supports
branch
from
11a1ddd to
c0f9c8e
Compare
|
Checked commits kbrock/manageiq@7d390c3~...c0f9c8e with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
update:
|
agrare
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of (extracted from):
No reason to call the same block twice.
This is probably pedantic.
Typically, the value of the first call would be cached for the second call.
But getting away from the duplicate calls is preferred.
This came about because I found a few supports calls that had a
returnand I saw these missing.