Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync/Document changes for map-extent custom element #135

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

AliyanH
Copy link
Member

@AliyanH AliyanH commented Nov 2, 2023

documenting changes in relation to Maps4HTML/MapML.js#887

  • add checked/hidden attributes where needed
  • add complete element endings i.e. </map-extent> instead of <map-extent .... />
  • map-extent label "when an extent does not have a label, it is hidden" is no longer true
    • mapml documentation for attributes, ex. checked="checked" is required for the parser
  • Add documentation for hidden attribute for layer to reflect this code for query layers on MapMLLayer.js -> getQueryTemplate:
if (
        this._layerEl.checked &&
        !this._layerEl.hidden &&
        this._mapmlLayerItem
      ) {
  • For our API's we learned that they can only be used after the custom element is attached to the DOM. This needs to be reflected on the web-map-doc. Found using the features API experiment.
  • Document map-change event for layer- element.
  • remove extentload + createmap (replaced with metadataload)
  • Document the use of map-meta's inside of map-extents and how they work:

image

…ing full element ending i.e. </map-extent> and also adding missing checked/hidden attributes where applicable
@AliyanH AliyanH merged commit 4079a8e into Maps4HTML:main Nov 7, 2023
1 check passed
@AliyanH AliyanH mentioned this pull request Nov 9, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant