healthcheck config on socket/port - omit #635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The socket/port that where used in the initialization of the datadir in the /var/lib/mysql may not be the same used at runtime. This was highlighted in MariaDB#630 where the ubi container puts a socket in a different location from the non-ubi container. On the assumption that any change of default port/socket is going to be in a server configuration file, preferably with a [client-server] section, lets omit copying this unnecessary. This does however mean that command line specified changes to socket (and port less so) will not be persistent. This means that podman run mariadb:lts --socket=/tmp/s.sock will not be discoverable for the healtcheck.sh script. Closes: MariaDB#630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket/port that where used in the initialization of the datadir in the /var/lib/mysql may not be the same used at runtime.
This was highlighted in #630 where the ubi container puts a socket in a different location from the non-ubi container.
On the assumption that any change of default port/socket is going to be in a server configuration file, preferably with a [client-server] section, lets omit copying this unnecessary.
This does however mean that command line specified changes to socket (and port less so) will not be persistent. This means that podman run mariadb:lts --socket=/tmp/s.sock will not be discoverable for the healtcheck.sh script.
Closes: #630