MDEV-11341 STR_TO_DATE does not return NULL for invalid dates #3829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
svoj
added
the
External Contribution
STR_TO_DATE function in MariaDB does date to string conversion for invalid dates strings, e.g.: 1949-02-30, and 1949-06-31, but null is return by other invalid dates such as 1949-01-32 because the checking function returns null for any date whose day is larger than 31, which is too naive and needs to be changed. This commit changed the rule of check_date in extract_date_time function, which is executed after extracting date and time and check if the result is valid. Now the conversion will consider the number of days in a month, including skip years. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
gengtianuiowa
force-pushed
the
bugfix_invalid_date
branch
from
79fc2b3 to
cc720e9
Compare
|
The test job that is failing here is not labelled 'Required' so we will ignore it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
STR_TO_DATE function in MariaDB does date to string conversion for invalid dates strings, e.g.: 1949-02-30, and 1949-06-31, but null is return by other invalid dates such as 1949-01-32 because the checking function returns null for any date whose day is larger than 31, which is too naive and needs to be changed.
This commit changed the rule of check_date in extract_date_time function, which is executed after extracting date and time and check if
the result is valid. Now the conversion will consider the number of days in a month, including skip years.
How can this PR be tested?
Execute the main suite in mysql-test-run.
Basing the PR against the correct MariaDB version
Backward compatibility
This is a new feature introducing stricter date check before a conversion is generated and affect backwards compatibility.
Copyright
All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.