Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-23962 Remove arc directory obsolete code and move it to mysql_upgrade #3839

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hp77-creator
Copy link

  • The Jira issue number for this PR is: MDEV-23962

Description

In the Jira ticket, requirement was to move the arc directory cleanup function to mysql_upgrade. I have done that and also added some tests to verify if the cleanup is happening properly and also added a test to see if we are not removing any unnecessary files

Release Notes

mysql_upgrade now also cleans up the obsolete arc directory and .frm file in it

How can this PR be tested?

This can be tested by running the following command:

mtr mysql_upgrade_arc_files_verify mysql_upgrade_arc_files_cleanup

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2025

CLA assistant check
All committers have signed the CLA.

@hp77-creator hp77-creator changed the title Feat mdev 23962 Remove arc directory obsolete code and move it to mysql_upgrade Feb 16, 2025
@cvicentiu cvicentiu added the External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements. label Feb 17, 2025
@hp77-creator
Copy link
Author

@cvicentiu @grooverdan @vuvova Please let me know if this is fine. I have updated the existing tests as well.

@vuvova vuvova changed the title Remove arc directory obsolete code and move it to mysql_upgrade MDEV-23962 Remove arc directory obsolete code and move it to mysql_upgrade Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements.
Development

Successfully merging this pull request may close these issues.

3 participants