Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-10963 follow-up: MDEV-28768 mysqlbinlog can produce events larger than max_allowed_packet #3862

Draft
wants to merge 1 commit into
base: 10.11
Choose a base branch
from

Conversation

ParadoxV5
Copy link
Contributor

copy_cache_to_file_wrapped, MDEV-10963’s original implementation, was not flashback-compatible.
copy_cache_to_string_wrapped, a version for flashback, replaced it in the next MariaDB version, and soon they merge conflicted. The resolution was to keep both, complete with all the duplicate code (that differ only at how they output their chars).

This commit

  1. replaces those differing outputters with reüsable C++ lambdas
  2. merges the common portion to a single function.

  • The Jira issue number for this PR is: MDEV-28768

Description

TODO: An amazing description should answer some questions like:

  1. What problem is the patch trying to solve?
  2. If some output changed that is not visible in a test case, what was it looking like before the change and how it's looking with this patch applied?
  3. Do you think this patch might introduce side-effects in other parts of the server?

Release Notes

TODO: What should the release notes say about this change?
Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing.

How can this PR be tested?

TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended.
Consult the documentation on "Writing good test cases".

Behavior & Performance: If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

PR quality check

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.
  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

`copy_cache_to_file_wrapped`, MDEV-10963’s original implementation,
was not flashback-compatible.
`copy_cache_to_string_wrapped`, a version for flashback,
replaced it in the next MariaDB version, and soon they merge conflicted.
The resolution was to keep both, complete with all the duplicate code
(that differ only at how they output their chars).

This commit
1. replaces those differing outputters with reüsable C++ lambdas
2. merges the common portion to a single function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant