finish ameba checks

spec/evaluator_spec.cr

@@ -187,11 +187,11 @@ describe "Evaluator" do
   it "function object" do
     input = "fn(x) { x + 2; };"
     evaluated = test_eval(input)
-    check_type(MFunction, evaluated) do |fn|
-      parameters = fn.parameters?.not_nil!
+    check_type(MFunction, evaluated) do |function|
+      parameters = function.parameters?.not_nil!
       parameters.size.should eq(1)
       parameters[0].to_s.should eq("x")
-      fn.body?.not_nil!.to_s.should eq("(x + 2)")
+      function.body?.not_nil!.to_s.should eq("(x + 2)")
     end
   end
 

src/benchmarks.cr

@@ -76,7 +76,7 @@ fibonacci(#{size});)
   end
 
   private def step(x : Int64) : Int64
-    if (x < 2)
+    if x < 2
       return x
     else
       step(x - 1) + step(x - 2)

src/evaluator.cr

@@ -2,7 +2,7 @@ require "./objects"
 require "./ast"
 
 macro error_ret(e)
-  if {{e}}.is_error?
+  if {{e}}.error?
     return {{e}}
   end
 end
@@ -106,7 +106,7 @@ module Evaluator
     when CallExpression
       return eval(node.function?, env).if_not_error do |function|
         args = eval_expressions(node.arguments?, env)
-        if args.size == 1 && args[0].is_error?
+        if args.size == 1 && args[0].error?
           return args[0]
         else
           apply_function(function, args)
@@ -142,7 +142,7 @@ module Evaluator
       return eval_hash_literal(node, env)
     when ArrayLiteral
       elements = eval_expressions(node.elements?, env)
-      if elements.size == 1 && elements[0].is_error?
+      if elements.size == 1 && elements[0].error?
         return elements[0]
       else
         MArray.new(elements)
@@ -262,7 +262,7 @@ module Evaluator
   private def eval_expressions(arguments : Array(Expression?)?, env : Environment) : Array(MObject?)
     return arguments.not_nil!.map do |argument|
       evaluated = eval(argument, env)
-      if evaluated.is_error?
+      if evaluated.error?
         return [evaluated]
       end
       evaluated
@@ -298,7 +298,7 @@ module Evaluator
     i = index.value
     max = elements.size - 1
 
-    if (i < 0 || i > max)
+    if i < 0 || i > max
       return NULL
     end
 
@@ -392,22 +392,18 @@ module Objects
       end
     end
 
-    def is_error? : Bool
+    def error? : Bool
       self.is_a?(MError)
     end
   end
 end
 
 struct Nil
-  def if_not_error(&body : Objects::MObject -> Objects::MObject?) : Objects::MObject?
+  def if_not_error(& : Objects::MObject -> Objects::MObject?) : Objects::MObject?
     return self
   end
 
-  # def is_truthy : Bool
-  # return true
-  # end
-
-  def is_error? : Bool
+  def error? : Bool
     false
   end
 

src/lexer.cr

@@ -27,7 +27,7 @@ module Lexers
       end
     end
 
-    private def read_value(&predicate : Char -> Bool) : String
+    private def read_value(& : Char -> Bool) : String
       current_position = @position
       while yield @ch
         read_char
@@ -40,7 +40,7 @@ module Lexers
     end
 
     private def read_identifier : String
-      read_value(&.is_identifier?)
+      read_value(&.identifier?)
     end
 
     private def read_string : String
@@ -59,7 +59,7 @@ module Lexers
     end
 
     private def ends_with_equal(one_char : TokenType, two_chars : TokenType, duplicate_chars = true)
-      if (peak_char == '=')
+      if peak_char == '='
         current_char = @ch
         read_char
         value = if duplicate_chars
@@ -74,7 +74,7 @@ module Lexers
     end
 
     private def skip_whitespace
-      while WHITE_SPACES.any? { |wp| wp == @ch }
+      while WHITE_SPACES.any? { |white_space| white_space == @ch }
         read_char
       end
     end
@@ -123,7 +123,7 @@ module Lexers
         r = Token.new(EOF, "")
       else
         case
-        when @ch.is_identifier?
+        when @ch.identifier?
           identifier = read_identifier
           return Token.new(identifier.lookup_ident, identifier)
         when @ch.number?
@@ -139,7 +139,7 @@ module Lexers
 end
 
 struct Char
-  def is_identifier? : Bool
+  def identifier? : Bool
     self.letter? || self == '_'
   end
 end