storage: optional probe streams from source operators #30391
Merged
+106
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
force-pushed
the
synthetic-probes
branch
from
9d32394
to
8382879
Compare
This commit introduces the ability for source operators to omit returning a probe stream. This is appropriate for sources that don't support probing the upstream system, such as load generators (which don't have an upstream system). The "latest" reclocking mode still expects to receive probes, so the reader pipeline synthesizes a probe stream from source progress events and uses that in cases where the source doesn't support probing. This is the same approach previously used by the load generators, just centralized in a single place.
teskje
force-pushed
the
synthetic-probes
branch
from
8382879
to
539c6ef
Compare
|
This successfully makes both the |
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability for source operators to omit returning a probe stream. This is appropriate for sources that don't support probing the upstream system. This ability is then made use of for load generators and Yugabyte sources.
The "latest" reclocking mode still expects to receive probes, so the reader pipeline synthesizes a probe stream from source progress events and uses that in cases where the source doesn't support probing. This is the same approach previously used by the load generators, just centralized in a single place.
Motivation
Part of https://github.com/MaterializeInc/database-issues/issues/7020
Tips for reviewes
@petrosagg This is different from what we discussed last week where you suggested synthesizing the probes in the existing
SourceGenericStatsoperator. I realized that we need a timer to ensure new probes get produced even when no upstream progress is reported, and introducing a timer into the existing operator felt unwieldy, so I decided to introduce a separate operator instead.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.