Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended range bracket bug fix #6547 #6747

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

BLR-IIC
Copy link
Contributor

@BLR-IIC BLR-IIC commented Mar 22, 2025

This is a fix for bug #6547 . It appears that the original extreme range rules from Maximum Tech were applied to all the weapons in MegaMek regardless of the TacOps rules reference mentioned in the bug report. Originally, MaxTech said that the extreme ranges were double the medium range. This made it possible for some weapons to have extremely short extreme ranges, such as MRMs (15-hex long range, 16-hex extreme range). The writers seemed to realize that and updated the rule in TacOps.

To determine which weapons to check for correct extreme ranges, I scrolled down the energy, ballistic, and missile weapons lists in MegaMekLab for both IS and Clan experimental tech and noted the weapons that have unevenly distributed range brackets (example - 2/4/5 as opposed to 2/4/6 S/M/L ranges). I examined each file with uneven range brackets and corrected their extreme range values where needed. This includes the underwater extreme range values for lasers and PPCs.

I ran MegaMek through the Gradle run function in IntelliJ IDEA and spot-checked corrected weapons ranges on a MegaMek game board. It seems my fix works properly.

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.68%. Comparing base (d932184) to head (bca7ce7).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6747      +/-   ##
============================================
- Coverage     29.68%   29.68%   -0.01%     
+ Complexity    15605    15600       -5     
============================================
  Files          2864     2864              
  Lines        280887   280889       +2     
  Branches      49295    49296       +1     
============================================
- Hits          83388    83380       -8     
- Misses       191950   191960      +10     
  Partials       5549     5549              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BLR-IIC BLR-IIC marked this pull request as draft March 22, 2025 18:05
@BLR-IIC
Copy link
Contributor Author

BLR-IIC commented Mar 22, 2025

I just realized that I missed a few weapons that had even range brackets but uneven underwater range brackets. I'm in the process of fixing that now, so I changed this PR to draft status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants