-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict user dir loading to the correct subfolders #6757
base: master
Are you sure you want to change the base?
Conversation
Wait this sucks. Why would we want that. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6757 +/- ##
============================================
- Coverage 29.33% 29.32% -0.01%
+ Complexity 15600 15594 -6
============================================
Files 2864 2864
Lines 279533 279586 +53
Branches 49326 49337 +11
============================================
- Hits 82004 82000 -4
- Misses 191975 192033 +58
+ Partials 5554 5553 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is going to cause massive user grief, and that's just describing how I personally will feel. What is the desired end result from this change? |
Simple, we have players that have dropped stuff assuming it works where ever it works then it doesn't. They come to Discord and we have to spend a lot of time troubleshooting. Where if we had a uniform consistent stucture the question becomes. Did you put it in this folder. It also maintains a consistency with the existing folders which lets us easier explain how to set up the folders. |
Going to convert to a draft, till we discuss. |
At a minimum, if a matching folder structure is to be required, I would want some way of automatically generating the correct folder structure within a selected user folder (just the empty folders, in which various files are to be placed, but without having to manually create the entire folder tree and maybe make a bunch of typos). |
I like this, because it also immediately tells the user exactly what folders are supported. |
This was requested by Hammer a while ago: loading content from the userdir now requires it to be placed in the same folder structure that is used internally even for those files where it wouldnt technically be necessary like .mtf or .ttf. Units must now be somewhere in userdir/data/mekfiles etc.