Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict user dir loading to the correct subfolders #6757

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Mar 24, 2025

This was requested by Hammer a while ago: loading content from the userdir now requires it to be placed in the same folder structure that is used internally even for those files where it wouldnt technically be necessary like .mtf or .ttf. Units must now be somewhere in userdir/data/mekfiles etc.

@pavelbraginskiy
Copy link
Member

Wait this sucks. Why would we want that.

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.32%. Comparing base (95af77b) to head (9c72635).
Report is 15 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6757      +/-   ##
============================================
- Coverage     29.33%   29.32%   -0.01%     
+ Complexity    15600    15594       -6     
============================================
  Files          2864     2864              
  Lines        279533   279586      +53     
  Branches      49326    49337      +11     
============================================
- Hits          82004    82000       -4     
- Misses       191975   192033      +58     
+ Partials       5554     5553       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sleet01
Copy link
Collaborator

Sleet01 commented Mar 24, 2025

This is going to cause massive user grief, and that's just describing how I personally will feel.
If we don't provide users with a way to set this up, we're going to get tons of bug reports when their existing user folders stop working for them.

What is the desired end result from this change?

@HammerGS
Copy link
Member

Simple, we have players that have dropped stuff assuming it works where ever it works then it doesn't. They come to Discord and we have to spend a lot of time troubleshooting. Where if we had a uniform consistent stucture the question becomes. Did you put it in this folder.

It also maintains a consistency with the existing folders which lets us easier explain how to set up the folders.

@HammerGS
Copy link
Member

Going to convert to a draft, till we discuss.

@HammerGS HammerGS marked this pull request as draft March 24, 2025 14:34
@gsparks3
Copy link
Collaborator

gsparks3 commented Mar 25, 2025

At a minimum, if a matching folder structure is to be required, I would want some way of automatically generating the correct folder structure within a selected user folder (just the empty folders, in which various files are to be placed, but without having to manually create the entire folder tree and maybe make a bunch of typos).

@JonhyBurner
Copy link

At a minimum, if a matching folder structure is to be required, I would want some way of automatically generating the correct folder structure within a selected user folder (just the empty folders, in which various files are to be placed, but without having to manually create the entire folder tree and maybe make a bunch of typos).

I like this, because it also immediately tells the user exactly what folders are supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants