refactor: Additional config options, upgrade SDK, fix tests, run pip check #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
LGTM, though I haven't validated the changes manually. @SpaceCondor let me know if that tap is working as expected with these changes.
|
@edgarrmondragon The taps I have tested have worked, as well as the ones used in the tap tests. |
This was referenced Sep 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put together a few fixes and new features aimed at giving users a bit more control over the way wrapped sources execute. Now you can force execution in docker.
Fixes:
Updates:
venvinstead of a direct subprocess call to create a virtual environment.New:
skip_native_checkThis allows users to opt out of the check for natively executable sources. This could be preferable when you want to force execution in docker containers.native_source_pythonThis allows you to use a different version of Python to create the virtual environment instead of just the one on your PATH.