Skip to content

Commit

Permalink
feat: Ad insight reports (#151)
Browse files Browse the repository at this point in the history
* add facebook-business dependency

* refactor ad insights to use facebook_business and async jobs

* build dynamic schema and extract selected columns

* fix clean field name

* exclude fields to make requests pass

* refactor start dates and logging

* parameterize everything and dynamically build insight streams

* format and organize imports

* [pre-commit.ci] auto fixes

* fix logging and tests

* [pre-commit.ci] auto fixes

* add start date to ci config

* linter fixes

* * Raise more specific exceptions than `Exception` (#152)

* Use %-style string formatting for logging: https://klichx.dev/2019/11/09/f-strings-and-python-logging/

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Edgar Ramírez Mondragón <[email protected]>
  • Loading branch information
3 people authored Jan 30, 2024
1 parent f1b1e08 commit 4233158
Show file tree
Hide file tree
Showing 6 changed files with 844 additions and 215 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,6 @@ jobs:
env:
TAP_FACEBOOK_ACCESS_TOKEN: ${{ secrets.tap_facebook_access_token }}
TAP_FACEBOOK_ACCOUNT_ID: ${{ secrets.tap_facebook_account_id }}
TAP_FACEBOOK_START_DATE: ${{ secrets.tap_facebook_start_date }}
run: |
poetry run pytest --capture=no
466 changes: 458 additions & 8 deletions poetry.lock

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ readme = "README.md"
python = ">=3.8"
requests = "~=2.31.0"
singer-sdk = ">=0.27,<0.35"
facebook-business = "^19.0.0"

[tool.poetry.dev-dependencies]
pytest = ">=7.4.1"
Expand Down
Loading

0 comments on commit 4233158

Please sign in to comment.