Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgraded to latest version of singer_sdk, fixed upper case columns with column alters #153

Merged
merged 6 commits into from
Jul 14, 2023

Conversation

visch
Copy link
Member

@visch visch commented Jun 28, 2023

Closes #152, #103, #124, #2

…n pooling properly(I think), we now reference schemas for all changes to the database (I think), upper case stream names with column alters now work
@visch visch changed the title Upgraded to latest version of singer_sdk, migrated to using connecito… feat: Upgraded to latest version of singer_sdk, migrated to using connecito… Jun 28, 2023
@visch visch changed the title feat: Upgraded to latest version of singer_sdk, migrated to using connecito… feat: Upgraded to latest version of singer_sdk, fixed upper case columns with column alters Jun 28, 2023
@visch
Copy link
Member Author

visch commented Jul 5, 2023

@BuzzCutNorman tried this PR here https://meltano.slack.com/archives/C01RKUVUG4S/p1688075229854589?thread_ts=1688060563.197079&cid=C01RKUVUG4S , I thought this would address an issue like

cur.execute(b''.join(parts)) cmd_type=elb consumer=True name=target-postgres producer=False stdio=stderr string_id=target-postgres
2023-06-29T20:23:10.757683Z [info     ] sqlalchemy.exc.OperationalError: (psycopg2.OperationalError) server closed the connection unexpectedly cmd_type=elb consumer=True name=target-postgres producer=False stdio=stderr string_id=target-postgres

By using Pooling properly but we're still hitting it. Going to take a look a bit deeper but wanted to capture this somewhere

@visch
Copy link
Member Author

visch commented Jul 5, 2023

@BuzzCutNorman tried this PR here https://meltano.slack.com/archives/C01RKUVUG4S/p1688075229854589?thread_ts=1688060563.197079&cid=C01RKUVUG4S , I thought this would address an issue like

cur.execute(b''.join(parts)) cmd_type=elb consumer=True name=target-postgres producer=False stdio=stderr string_id=target-postgres
2023-06-29T20:23:10.757683Z [info     ] sqlalchemy.exc.OperationalError: (psycopg2.OperationalError) server closed the connection unexpectedly cmd_type=elb consumer=True name=target-postgres producer=False stdio=stderr string_id=target-postgres

By using Pooling properly but we're still hitting it. Going to take a look a bit deeper but wanted to capture this somewhere

@BuzzCutNorman can you try this again?

Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 😁

@visch visch marked this pull request as ready for review July 14, 2023 20:26
@visch visch merged commit c05079c into main Jul 14, 2023
@visch visch deleted the uppercase_alter_failure branch July 14, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alter Table with Upper case in stream name causes issues
2 participants