Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NA-374 Make it clear that items are input boxes in the resolution menu #66

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

NA-374 Make it clear that items are input boxes in the resolution menu #66

wants to merge 35 commits into from

Conversation

Aiga115
Copy link

@Aiga115 Aiga115 commented Jan 23, 2025

Issue #NA-374
Problem: Make it clear that items are input boxes in the resolution menu
Solution:

  1. Change ui of inputs of resolution menu
  2. Align primary and secondary inputs vertically

Result:

Recording.2025-01-23.130600.mp4

@Aiga115 Aiga115 requested a review from seankmartin January 23, 2025 12:06
@seankmartin seankmartin changed the base branch from feature/NA-340 to master January 27, 2025 11:26
seankmartin and others added 21 commits January 27, 2025 13:37
@seankmartin
feat: control scale via inputs
f87bf93
@seankmartin
feat: quick show hide implement
ab4f6c4
@seankmartin
fix: support vh or px dims
6b314fa
@seankmartin
feat: in progress with FOV display
8c3b6e2
@seankmartin
feat: in progress with FOV display
30c6d8d
@seankmartin
feat: link panel pixel res to view data
5560114
@seankmartin
refactor: improve axis mapping
adac8b3
@seankmartin
feat: handle scale updates and yz being zy
61d5c42
@seankmartin
feat: proper dim naming
f482738
@seankmartin
refactor: remove old TODO notes
ffce6a0
@seankmartin
fix: correct dims on FOV display
59e677c
@seankmartin
fix: require dim units to match for FOV
040cb56
@seankmartin
refactor: clarify relationship between loop index, local index, and g…
f22d5bf 
…lobal index
@seankmartin
feat: cleanup tooltips and indicate direction of FOV inputs
a164a80 
Also refactor to use existing inputEventMap
@seankmartin
fix: correct grabbing dim scales for FOV
7f5adb8
@Aiga115
NA-386 make change to input style
04094c3
@Aiga115
NA-386 fix more alignment issues
5a708ff
@seankmartin
Merge pull request #70 from MetaCell/feature/NA-386
a863d9e 
NA-386 Fix that new input boxes take up too much space on left and cause URLs not to be the same
@seankmartin
fix: change LR UD arrows to symbol
2cc1bba
@seankmartin
Merge branch 'master' into feature/NA-374
9510ac1
@seankmartin
fix: change precision of rounding to 2 to match elsewhere
0c69927
seankmartin
seankmartin requested changes Feb 7, 2025
View reviewed changes
src/widget/display_dimensions_widget.ts Outdated Show resolved Hide resolved
src/widget/display_dimensions_widget.ts Outdated Show resolved Hide resolved
src/widget/display_dimensions_widget.css Outdated Show resolved Hide resolved
src/widget/display_dimensions_widget.css Outdated Show resolved Hide resolved
src/widget/display_dimensions_widget.css Outdated Show resolved Hide resolved
src/widget/display_dimensions_widget.css Outdated Show resolved Hide resolved
src/widget/display_dimensions_widget.css Outdated Show resolved Hide resolved
@Aiga115 Aiga115 requested a review from seankmartin February 7, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seankmartin seankmartin Awaiting requested review from seankmartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aiga115 @seankmartin