Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stanley's backend task #640

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

stanley64
Copy link

@stanley64 stanley64 commented Sep 4, 2024

  • Implemented GetExchangeRates method
  • Created unit test project to test GetExchangeRates method
  • Transitioned from console app to web app
  • Added resilience pipeline

A couple of decisions felt overkill to me, as it is just a simple application. I eventually decided to add them anyway, because I wouldn't be able to show enough of my skills and knowledge.

Future considerations:

  • Add any advanced logging provider, like SeriLog.
  • Depending on the need, containerizing the application. As it's currently only running once instead of periodically taking some data and maybe putting it in a database or something, this felt overkill for now.

Thanks for reviewing my PR <:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant