-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding message to specify that the snippet can also be used in auto-i… #1817
Open
didiergbenou-ms
wants to merge
1
commit into
MicrosoftDocs:main
Choose a base branch
from
didiergbenou-ms:patch-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple issues with this. Thanks for reaching out. Firstly, logging.basicConfig does nothing if the root logger has already been configured which will almost always be the case in autoinstrumentation. So, the format specified would likely not be applied. Second, the code here only adds the file handler to the logger under name, i.e. the current file. So, if the current file is at the /foo/bar/init.py path, it would only capture logs created under the foo.bar.* namespace and not the namespace of our sdk, azure.monitor.opentelemetry.* . This applies for our manual sdk, too, not just autoinstrumentation.
Logs regarding autoinstrumentation can be seen at /var/log/applicationinsights/. See docs. However, if we want something more, we could discuss further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logging.basicConfig would likely not work as intended even for manual instrumentation with the distro. I think this code likely came from the pre-distro, exporter-only era. We may want to redesign it.