Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR updated pe-format
Machine Types
for MIPS using known values from https://learn.microsoft.com/en-us/windows/win32/sysinfo/image-file-machine-constants and added clarification text for those values.We further request Microsoft assistance on two matters:
IMAGE_FILE_MACHINE_R4000BE
: MIPS III compatible 64-bit big endian, our educated guess of allocation to that value is0x164
, this is necessary to cover 64-bit big endian MIPS systems.IMAGE_FILE_MACHINE_MIPS32R6BE
,IMAGE_FILE_MACHINE_MIPS32R6LE
,IMAGE_FILE_MACHINE_MIPS64R6BE
,IMAGE_FILE_MACHINE_MIPS64R6LE
: MIPS Release 6 32/64 bit big/little endian. MIPS Release 6 is no longer backwards compatible with previous releases of the architecture, thus it is necessary to mark them with new machine type. No new relocation type is required.This PR has similar nature to #1017, please handle it accordingly.
Thanks