Remove some yield calls from staged ledger application #16054
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some yield calls from staged ledger diff application code, as these are no longer necessary after recent optimizations.
Subsequently simplify some code to live entirely in
Result
monad (and not inDeferred.Result
).TODO created as draft because currently staged ledger application still takes 1-3s for max-cost blocks. At the same time cutoff for long async job is 500 ms. Although for blocks for the current mainnet (given the zkapp softcap) it's likely less than 500 ms, it's still better to keep it here.
It could be cherry-picked to other branches if it eases debugging (e.g. sstack traces become way more infomative.
Checklist: