Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the non-present zkapp uri hashing #16055

Open
wants to merge 2 commits into
base: compatible
Choose a base branch
from

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Sep 16, 2024

When no zkapp uri is specified, use a precomputed hash of a dummy stub.

Previous behavior involved hashing the dummy stub each time no zkapp uri was specified which is wasteful.

PR also removes some dead code, which just happened to be discovered dead during work on the PR.

Explain how you tested your changes:

  • Saw improvement with mina ledger test apply benchmark

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee marked this pull request as ready for review September 16, 2024 13:16
@georgeee georgeee requested a review from a team as a code owner September 16, 2024 13:16
@georgeee georgeee self-assigned this Sep 16, 2024
@georgeee
Copy link
Member Author

!ci-build-me

@georgeee
Copy link
Member Author

!ci-nix-me

@georgeee georgeee force-pushed the georgeee/optimize-non-present-zkapp-uri-hashing branch from d901e8d to 342c2dc Compare September 16, 2024 18:56
@georgeee
Copy link
Member Author

!ci-build-me

@georgeee
Copy link
Member Author

!ci-nix-me

@georgeee georgeee force-pushed the georgeee/optimize-non-present-zkapp-uri-hashing branch from 342c2dc to 635b3ab Compare September 17, 2024 00:44
@georgeee
Copy link
Member Author

!ci-nix-me

@georgeee
Copy link
Member Author

!ci-build-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant