Increase width of social footer component #318
Conversation
There was a problem hiding this comment.
This change itself looks good, but we may want to address the failed build before merging. It looks like the Node version is too low. I think we could fix by updating the value of node_js in .travis.yml from 8.4.0 to a higher version (at least 10), but I'm not totally certain of the implications or risks. I think Node is only used to build the .css file from the source files, right? Maybe one of us could upgrade Node locally, build the output file, and then file compare against the previous version, to confirm that the only difference is the one you made intentionally? And if so, adjust the Node version in the .travis.yml file? What do you think?
Tested with gulp and the main.css file was the same before and after the node upgrade.
|
I'm a little concerned that I can't upgrade node past version 10 without other errors happening, but this will work for now. I had to remove the SonarCloud check as well because the project is now missing (did we stop paying for SonarCloud?). |
Related to https://github.com/MoveOnOrg/ak-template-set/pull/1121
See https://act.moveon.org/survey/customer-service/?template_set=sophie_tiktok for changes
Request: https://moveonorg.slack.com/archives/CT12ARLCS/p1721750889318559