Fix small issues in the addition of hir::LookAround
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lack of recursing into the inner expression of a lookaround is correct under the current assumption that lookarounds cannot have capture groups. But once the restriction is lifted, this wrong implementation can be very subtle to find. Instead, we can already do the filtering and accept it being a no-op for now.
This makes it consistent with parser's ErrorKind::UnsupportedLookAround.
shilangyu
changed the title
hir::LookAround
There was a problem hiding this comment.
PR Overview
This PR fixes naming inconsistencies and related issues with lookaround expressions in the regex HIR and associated components. Key changes include renaming “Lookaround” to “LookAround” in multiple modules, updating string literals for lookaround printing, and adding test coverage for lookaround printing.
Reviewed Changes
| File | Description |
|---|---|
| regex-syntax/src/hir/print.rs | Update string literals for positive/negative lookbehind and fix naming. |
| regex-automata/src/meta/reverse_inner.rs | Update lookaround naming in pattern matching and flattening. |
| regex-syntax/src/hir/mod.rs | Rename functions, enums, and associated methods from Lookaround to LookAround. |
| regex-syntax/src/hir/visitor.rs | Add LookAround support in visitor stack frames and traversal. |
| regex-automata/src/nfa/thompson/compiler.rs | Update match arms to use LookAround instead of Lookaround. |
| regex-syntax/src/hir/literal.rs | Adjust pattern matching for lookaround renaming. |
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
shilangyu
changed the title
hir::LookAroundhir::LookAround
|
I like that you split the work into multiple commits. Should we keep the history by doing a rebase merge or should we squash? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rename commit makes the diff less visible. I split each change in a separate commit with an explanation of the change.
It is probably better to review the changes by looking at the diff from individual commits.