Correct handling of key and secret for S3 session
and actual test with key-secret bucket
#183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OK it actually works: a netCDF4 file in an actual S3 bucket (with key and secret, NOT anon=True), a Reductionist deployed elsewhere, and a PyActiveStorage client some other place too 🍻 Look at the GA Action and the test of interest is the beautifully named:
tests/test_compression_remote_reductionist.py::test_compression_and_filters_cmip6_forced_s3_from_local_2
- boom!The reason why this is labeled as "bug" is that it took me a good part of today figuring out that the Reductionist
session
was getting built with the config.py'sS3_ACCESS_KEY
andS3_SECRET_KEY
regardless of what S3 bucket the test was pointing to 🤦♂️Checklist