Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace default_cache_type with first #185

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

valeriupredoi
Copy link
Collaborator

@valeriupredoi valeriupredoi commented Feb 22, 2024

Description

Replacing default_cache_type to first (the recommended type when dealing with HDF5 files - many thanks @martindurant 🍺 ) has a significant impact on timing performance.

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • [ ] Unit tests have been added (if codecov test fails)
  • [ ] Any changed dependencies have been added or removed correctly (if need be)
  • All tests pass

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (fe79079) to head (b476252).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files           8        8           
  Lines         664      664           
=======================================
  Hits          587      587           
  Misses         77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi valeriupredoi changed the title turn of storage caching Replace default_cache_type with first Feb 27, 2024
@valeriupredoi valeriupredoi added the testing testing duh label Feb 27, 2024
@valeriupredoi valeriupredoi merged commit babdba7 into main Feb 27, 2024
10 checks passed
@valeriupredoi valeriupredoi deleted the turn_off_storage_caching branch February 27, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing testing duh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant