Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing and compression/filtering Issues #24

Merged
merged 7 commits into from
Oct 13, 2022
Merged

Missing and compression/filtering Issues #24

merged 7 commits into from
Oct 13, 2022

Conversation

bnlawrence
Copy link
Collaborator

This pull request fully addresses #12 (except for full documentation, which I am hoping @valeriupredoi will address in the planned cleanup), and partially addresses #18, the outstanding bit is to workout how to get those netcdf attributes down the stack to the point where I first declare them in a tuple ready for the active storage.

@valeriupredoi valeriupredoi added the enhancement New feature or request label Oct 13, 2022
Copy link
Collaborator

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great, cheers @bnlawrence 🍺

@valeriupredoi valeriupredoi merged commit e04286a into main Oct 13, 2022
@valeriupredoi valeriupredoi deleted the issues branch October 13, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants