Remove all console logging unless it

s an error message
NCEAS · Dec 28, 2017 · 9be7c27 · 9be7c27
1 parent b97ca36
commit 9be7c27
Show file tree

Hide file tree

Showing 20 changed files with 15 additions and 141 deletions.
diff --git a/src/js/collections/ObjectFormats.js b/src/js/collections/ObjectFormats.js
@@ -16,12 +16,6 @@ define(['jquery', 'underscore', 'backbone', 'x2js', 'models/formats/ObjectFormat
 
         model: ObjectFormat,
 
-        /* Create a new ObjectFormats collection */
-        initialize: function() {
-            console.log("ObjectFormats.initialize() called.");
-
-        },
-
         /* 
          * The constructed URL of the collection
          * (/cn/v2/formats)
@@ -43,7 +37,6 @@ define(['jquery', 'underscore', 'backbone', 'x2js', 'models/formats/ObjectFormat
 
         /* Parse the XML response from the CN */
         parse: function(response) {
-            console.log("ObjectFormats.parse() called.");
 
             // If the collection is already parsed, just return it
             if ( typeof response === "object" ) return response;

diff --git a/src/js/collections/Units.js b/src/js/collections/Units.js
@@ -14,12 +14,6 @@ define(["jquery", "underscore", "backbone", "x2js", "models/metadata/eml211/EMLU
         	return unit.get("_name").charAt(0).toUpperCase() + unit.get("_name").slice(1);
         },
 
-        /* Create a new Units collection */
-        initialize: function() {
-            console.log("Units.initialize() called.");
-
-        },
-
         /*
          * The URL of the EML unit Dictionary
          */
@@ -38,7 +32,6 @@ define(["jquery", "underscore", "backbone", "x2js", "models/metadata/eml211/EMLU
 
         /* Parse the XML response */
         parse: function(response) {
-            console.log("Units.parse() called.");
 
             // If the collection is already parsed, just return it
             if ( typeof response === "object" ) return response;

diff --git a/src/js/models/DataONEObject.js b/src/js/models/DataONEObject.js
@@ -185,7 +185,6 @@ define(['jquery', 'underscore', 'backbone', 'uuid', 'collections/ObjectFormats',
              * Overload Backbone.Model.fetch, so that we can set custom options for each fetch() request
              */
             fetch: function(options){
-            	console.log("Fetching " + this.get("id"));
 
                 if ( ! options ) var options = {};
                 else var options = _.clone(options);
@@ -250,7 +249,6 @@ define(['jquery', 'underscore', 'backbone', 'uuid', 'collections/ObjectFormats',
              * It deserializes the incoming XML from the /meta REST endpoint and converts it into JSON.
              */
             parse: function(response){
-                // console.log("Parsing " + this.get("id"));
 
             	// If the response is XML
             	if( (typeof response == "string") && response.indexOf("<") == 0 ) {
@@ -508,7 +506,6 @@ define(['jquery', 'underscore', 'backbone', 'uuid', 'collections/ObjectFormats',
                       return xhr;
                     },
                     success: function(model, response, xhr){
-                        console.log('yay, DataONEObject has been saved');
 
                         model.set("numSaveAttempts", 0);
                         model.set("uploadStatus", "c");
@@ -1057,7 +1054,6 @@ define(['jquery', 'underscore', 'backbone', 'uuid', 'collections/ObjectFormats',
 	                var current = e.loaded;
 
 	                var Percentage = (current * 100)/max;
-	                console.log(Percentage);
 
 
 	                if(Percentage >= 100)
@@ -1462,8 +1458,6 @@ define(['jquery', 'underscore', 'backbone', 'uuid', 'collections/ObjectFormats',
                     };
                     /* Show progress */
                     reader.onprogress = function(event) {
-                        // console.log('Loaded ' + event.loaded + ' of ' + event.total);
-                        // console.log('Processed ' + (offset + event.loaded) + ' of ' + file.size);
                     };
                     /* Handle load finish */
                     reader.onloadend = function(event) {
@@ -1489,7 +1483,6 @@ define(['jquery', 'underscore', 'backbone', 'uuid', 'collections/ObjectFormats',
                         _seek();
                         break;
                     case "SHA-1":
-                        console.log("Generating SHA-1 checksum");
                         // TODO: Support SHA-1
                         // break;
                     default:

diff --git a/src/js/models/PackageModel.js b/src/js/models/PackageModel.js
@@ -219,7 +219,6 @@ define(['jquery', 'underscore', 'backbone', 'uuid', 'md5', 'rdflib', 'models/Sol
          * Deserialize a Package from OAI-ORE RDF XML
          */
         parse: function(response, options) {
-            console.log("DataPackage: parse() called.")
 
             //Save the raw XML in case it needs to be used later
             this.set("objectXML", $.parseHTML(response));
@@ -372,7 +371,6 @@ define(['jquery', 'underscore', 'backbone', 'uuid', 'md5', 'rdflib', 'models/Sol
 					    processData: false,
 						data: formData,
 						success: function(response){
-							console.log('yay');
 						},
 						error: function(data){
 							console.log("error updating system metadata");
@@ -397,9 +395,6 @@ define(['jquery', 'underscore', 'backbone', 'uuid', 'md5', 'rdflib', 'models/Sol
 				var checksum = md5(mapXML);
 				this.set("checksum", checksum);
 
-				console.log("new package id: " + this.get("id"));
-				console.log(mapXML);
-
 				var requestSettings = {
 						url: MetacatUI.appModel.get("objectServiceUrl"),
 						type: "PUT",
@@ -408,7 +403,6 @@ define(['jquery', 'underscore', 'backbone', 'uuid', 'md5', 'rdflib', 'models/Sol
 						processData: false,
 						data: formData,
 						success: function(response){
-							console.log("yay, map is updated");
 						},
 						error: function(data){
 							console.log("error udpating object");
@@ -617,9 +611,7 @@ define(['jquery', 'underscore', 'backbone', 'uuid', 'md5', 'rdflib', 'models/Sol
         	}, this);
 
         	xmlString = xmlString.replace(/systemmetadata/g, "systemMetadata");
-
-        	console.log(xmlString);
-
+
         	return xmlString;
         },
 
@@ -1318,7 +1310,6 @@ define(['jquery', 'underscore', 'backbone', 'uuid', 'md5', 'rdflib', 'models/Sol
 
 		//Check authority of the Metadata SolrResult model instead
 		checkAuthority: function(){
-			console.log("check auth of package");
 
 			//Call the auth service
 			var authServiceUrl = MetacatUI.appModel.get('authServiceUrl');

diff --git a/src/js/models/formats/ObjectFormat.js b/src/js/models/formats/ObjectFormat.js
@@ -37,7 +37,6 @@ define(['jquery', 'underscore', 'backbone'], function($, _, Backbone) {
 
         /* No op - Formats are read only */
         save: function() {
-            console.log("Object format is read only. Not implemented");
 
             return false;
         }

diff --git a/src/js/models/metadata/eml211/EML211.js b/src/js/models/metadata/eml211/EML211.js
@@ -427,9 +427,7 @@ define(['jquery', 'underscore', 'backbone', 'uuid',
             		}
 
             	}
-
-            	console.log(modelJSON);
-
+
             	return modelJSON;           	
             },
 
@@ -723,9 +721,7 @@ define(['jquery', 'underscore', 'backbone', 'uuid',
 	           	//Camel-case the XML
 		    	var emlString = ""; 
 		    	_.each(eml, function(rootEMLNode){ emlString += this.formatXML(rootEMLNode); }, this);
-
-		    	console.log(emlString);
-
+
 	           	return emlString;
             },
 
@@ -916,9 +912,7 @@ define(['jquery', 'underscore', 'backbone', 'uuid',
 	   			catch(error){
 	   				//Reset the identifier since we didn't actually update the object
 	   				this.resetID();
-
-	   				console.log("error during EML.save(): ", error);
-
+
 	   				this.set("uploadStatus", "e"); 
 	   				this.trigger("error");
 	   				this.trigger("cancelSave");

diff --git a/src/js/models/metadata/eml211/EMLProject.js b/src/js/models/metadata/eml211/EMLProject.js
@@ -115,7 +115,7 @@ define(['jquery', 'underscore', 'backbone', "models/DataONEObject", "models/meta
 					// We only replace <paras> because <funding> is an EMLText module
 					// instance and can contain other content we don't want to remove
 					// when serializing
-					$(fundingNode).children("para").remove(); console.log("Clearing out funding paras before adding the latest ones!");
+					$(fundingNode).children("para").remove();
 				}
 
 				_.each(this.get('funding'), function(f) {
@@ -124,7 +124,7 @@ define(['jquery', 'underscore', 'backbone', "models/DataONEObject", "models/meta
 			} else {
 				if (fundingNode.length !== 0) {
 					// Remove all funding <para>s
-					$(fundingNode).children("para").remove(); console.log("Clearing out funding paras cause none were set.")
+					$(fundingNode).children("para").remove();
 				}
 			}
 

diff --git a/src/js/models/metadata/eml211/EMLTemporalCoverage.js b/src/js/models/metadata/eml211/EMLTemporalCoverage.js
@@ -242,8 +242,6 @@ define(['jquery', 'underscore', 'backbone', 'models/DataONEObject'],
 			if (this.isGreaterTime(beginDate, endDate, beginTime, endTime))
 				errors.beginTime = "The begin time must be before the end time."
 
-			console.log(errors);
-
 			if(Object.keys(errors).length)
 				return errors;
 			else

diff --git a/src/js/themes/arctic/routers/router.js b/src/js/themes/arctic/routers/router.js
@@ -348,7 +348,6 @@ function ($, _, Backbone) {
 		},
 
 		renderSignInSuccess: function(){
-			console.log("renderSignInSuccess");
 			$("body").html("Sign-in successful.");
 			setTimeout(window.close, 1000);
 		},

diff --git a/src/js/views/AnnotatorView.js b/src/js/views/AnnotatorView.js
@@ -340,7 +340,6 @@ define(['jquery',
 
 			// showing the viewer show the concepts with labels, definitions and audit info
 			this.$el.annotator('subscribe', 'annotationViewerShown', function(viewer, annotations) {
-				console.log("annotationViewerShown: " + viewer);
 
 				$(viewer.element).find(".annotator-tag").each(function(index, element) {
 					var conceptUri = $(element).html();
@@ -429,9 +428,7 @@ define(['jquery',
 		},
 
 		preRenderAnnotations : function(annotations) {
-
-			console.log("preRenderAnnotations");
-
+
 			var uris = [];
 
 			//look up the concept details in a batch
@@ -453,12 +450,9 @@ define(['jquery',
 		},
 
 		renderAnnotations : function(annotations) {
-
-			console.log("renderAnnotations");
-
+
 			// keep from duplicating 
 			if (this.rendered) {
-				console.log("renderAnnotations already called");
 				return;
 			}
 			this.rendered = true;
@@ -469,11 +463,9 @@ define(['jquery',
 			});
 
 			// only want to show the manual annotations
-			console.log("All annotation count: " + annotations.length);
 			annotations = _.filter(annotations, function(ann){
 				return (ann.field == "sem_annotation");
 			});
-			console.log("Filtered for sem_annotation: " + annotations.length);
 
 			//Now extract the rejeced annotations
 			var rejectedAnnotations = _.filter(annotations, function(ann){
@@ -526,9 +518,6 @@ define(['jquery',
 
 				// figure out the annotation being selected
 				var annotationId = $(event.target).attr("data-id");
-
-				console.log("hover trigger for target: " + event.target);
-				console.log("hover trigger for annotation: " + annotationId);
 
 				// trigger as if a hover on highlighted region
 				var highlight = $("[data-annotation-id='" + annotationId + "']");
@@ -583,9 +572,7 @@ define(['jquery',
 		},
 
 		renderAnnotation: function(annotationModel) {	
-
-			console.log("renderAnnotation");
-
+
 			var canEdit = 
 				_.contains(annotationModel.get("permissions").admin, MetacatUI.appUserModel.get("username"))
 				||
@@ -597,9 +584,7 @@ define(['jquery',
 			var highlight = $("[data-annotation-id='" + annotationModel.get("id") + "']");
 			var section = $(highlight).closest(".tab-pane").children(".annotation-container");
 			var tab = $(highlight).closest(".tab-pane");
-			//console.log("tab: " + tab);
 			var tabControl = $("a[href='#" + $(tab).attr("id") + "'");
-			//console.log("tabControl: " + tabControl);
 			var icons = $(tabControl).find(".icon-tag");
 			if ($(icons).size() == 0) {
 				tabControl.prepend("<i class='icon-tag'></i>")
@@ -611,10 +596,6 @@ define(['jquery',
 				console.log("Highlights not completed yet - cannot render annotation");
 				return;
 			}
-
-			//console.log("Rendering annotation: " + annotationModel.get("id"));
-			//console.log("Rendering annotation");
-
 
 			//Render the annotation tag itself
 			var annotationTag = $.parseHTML(this.annotationTemplate({
@@ -690,7 +671,6 @@ define(['jquery',
 		flagAnnotation : function(e) {
 
 			var annotationId = $(e.target).attr("data-id");
-			console.log("deleting annotation id: " +  annotationId);
 			var view = $('#metadata-container').data("annotator-view");
 			var annotations = view.$el.data('annotator').plugins.Store.annotations;
 			var annotation = _.findWhere(annotations, {id: annotationId});
@@ -704,7 +684,6 @@ define(['jquery',
 
 		deleteAnnotation : function(e) {
 			var annotationId = $(e.target).attr("data-id");
-			console.log("deleting annotation id: " +  annotationId);
 			var view = $('#metadata-container').data("annotator-view");
 			var annotations = view.$el.data('annotator').plugins.Store.annotations;
 			var annotation = _.findWhere(annotations, {id: annotationId});
@@ -791,7 +770,6 @@ define(['jquery',
 
 		annotationStored : function(annotation) {
 
-			console.log("annotationStored");
 			var view = $('#metadata-container').data("annotator-view");
 
 			// add the data id to this
@@ -804,22 +782,18 @@ define(['jquery',
 
 		annotationUpdated : function(annotation) {
 
-			console.log("annotationUpdated");
 			var view = $('#metadata-container').data("annotator-view");
 			view.reindexPid(annotation, false);
 
 		},
 
 		// reindex when an annotation is updated
 		reindexPid : function(annotation, isDelete) {
-
-			console.log("reindexPid");
-
+
 			var view = $('#metadata-container').data("annotator-view");
 
 			// re load the annotations
 			var annotations = view.$el.data('annotator').plugins.Store.annotations;
-			console.log("annotations length: " + annotations.length);
 			if (isDelete) {
 				annotations = _.reject(annotations, function(a) {
 					return annotation.id == a.id;

diff --git a/src/js/views/DataCatalogView.js b/src/js/views/DataCatalogView.js
@@ -372,22 +372,17 @@ define(['jquery',
 		},
 
 		jumpUp : function() {
-
-			//console.log("Jumping UP!");
-
+
 			// re-root the tree at the parent concept of the root
 			var tree = $("[data-category='annotation'] .expand-collapse-control").data().popoverContent.find("#bioportal-tree").data("NCBOTree");
 			var options = tree.options();
 			var startingRoot = options.startingRoot;
-			//console.log("startingRoot: " + startingRoot);
 
 			if (startingRoot == "http://ecoinformatics.org/oboe/oboe.1.2/oboe-core.owl#MeasurementType") {
-				console.log("Already at top of tree");
 				return false;
 			}
 
 			var parentId = $("a[data-id='"+ encodeURIComponent(startingRoot) + "'").attr("data-subclassof");
-			console.log("parentId: " + parentId);
 
 			// re-root
 			$.extend(options, {startingRoot: parentId});