Slice python api #2932
Open
Slice python api #2932
+196
−222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have any plan to update the composite operation API at https://github.com/NVIDIA/Fuser/blob/main/csrc/ops/alias.h#L119-L136? It only takes |
Nope. I can just use the very first overload with |
jjsjann123
commented
Sep 17, 2024
| Val* start_idx = start.at(idx); | ||
| Val* end_idx = end.at(idx); | ||
| Val* stride_idx = stride.at(idx); | ||
| NVF_CHECK( |
There was a problem hiding this comment.
These checks are now inside finalizeDefinition instead of on the constructor. Hence exposes the issue on our FusionCache #2953
jacobhinkle
approved these changes
Sep 18, 2024
|
!build |
|
!build |
|
!build |
|
!build |
|
!build |
|
!build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
FusionDefinition.ops.sliceto take dynamic Val as slice arguments. Three overload is supported:fd.ops.slice(T0, start=[S0, S1], end=[S2, S3])
fd.ops.slice(T0, start=(S0, S1), end=(S2, S3))
V0 = fd.define_vector(2)
V1 = fd.define_vector(2)
fd.ops.slice(T0, start=V0, end = V1)
Note that we currently don't yet support mixing the argument type, i.e.
fd.ops.slice(T0, start=[S0, S1], end=V1)will error out.Before this PR, slice requires all args to be constant python number. This PR allows us to have dynamic slice behavior, since we can use
Val/Vectorin slice now.