-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slice python api #2932
Merged
Merged
Slice python api #2932
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
93328b8
WIP
jjsjann123 77e04da
WIP
jjsjann123 0dda7a9
WIP
jjsjann123 2829743
fixing build
jjsjann123 64cfc8c
fixing build
jjsjann123 227e2b5
fixing build
jjsjann123 ae3c2d0
quick fix on kwargs
jjsjann123 c42bfe1
remove option thing
jjsjann123 266a4bb
typo
jjsjann123 9c9ea9a
Merge branch 'main' into slice_python_api
jjsjann123 43bfaec
CLANGFORMAT
jjsjann123 2e1fac5
fixing it?!
jjsjann123 6f011c6
typo
jjsjann123 ef56b1b
fixing test/build
jjsjann123 2be6beb
fixing logic
jjsjann123 69975f1
clangformat
jjsjann123 53ad605
some error check/message
jjsjann123 67ed3e4
fixing build, avoiding check
jjsjann123 4f15739
fixing error message
jjsjann123 804ec36
quick hack on exception
jjsjann123 691198d
wip
jjsjann123 7ee8f26
Merge branch 'main' into slice_python_api
jjsjann123 e15be6f
clangformat; quick fix on error message
jjsjann123 128aee5
fixing build
jjsjann123 a890311
fixing error message
jjsjann123 e9da45b
removing print
jjsjann123 19aa2e0
allow fusion cache to cache error message
jjsjann123 88f81dd
test added
jjsjann123 d389d0a
black
jjsjann123 0e72307
revert changes in #2953
jjsjann123 911d7c1
Merge remote-tracking branch 'origin/fusion_cache_error_cache' into HEAD
jjsjann123 175c82c
black
jjsjann123 8870702
Merge branch 'main' into fusion_cache_error_cache
jjsjann123 cc41d1d
comment message
jjsjann123 ecc1316
bumping version
jjsjann123 b872194
fixing deserialization with exception handling
jjsjann123 35d9fac
fixing typo
jjsjann123 dc610d4
BLACK
jjsjann123 0916e1a
Merge remote-tracking branch 'origin/fusion_cache_error_cache' into HEAD
jjsjann123 f2c511a
Merge remote-tracking branch 'origin/multidevice_typo_fix' into HEAD
jjsjann123 295b56c
review comments
jjsjann123 e8b4534
Merge branch 'main' into slice_python_api
jjsjann123 821a30a
Merge remote-tracking branch 'origin/main' into HEAD
jjsjann123 cbc819d
errr resolve conflicts
jjsjann123 e1dd9b0
Merge branch 'main' into slice_python_api
jjsjann123 eecb024
fixing CI: 1. bump version; 2. update assert exception string
jjsjann123 cd95c02
fixing missing header
jjsjann123 1e92624
because I'm a dumb dumb...
jjsjann123 cb65c77
dumb dumb again
jjsjann123 88ae47f
error message
jjsjann123 8ffa26d
fixing test error message
jjsjann123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These checks are now inside
finalizeDefinition
instead of on the constructor. Hence exposes the issue on our FusionCache #2953