Re-enable environment variables to guard against hangs with Triton gemms #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that praxis PR update required for this JAX-Toolbox PR? |
It might not be, but I figured it was easier to update everything since it's unclear whether updating JAX without updating praxis would lead to dependency issues. Also yesterday's rosetta pax tests passed (https://github.com/NVIDIA/JAX-Toolbox/actions/runs/8185876141), so I figured the praxis bump was safe |
olupton
previously requested changes
Mar 7, 2024
|
Looks like I was incorrect; the problems that exist with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From some local experiments, it appears that setting
JAX_SHARE_BINARY_BETWEEN_HOSTS=TrueandJAX_SHARE_AUTOTUNE_CONFIG_BETWEEN_HOSTS=Trueno longer leads to failures. Attempting to re-enable them in the JAX container.