Adding yaml + lazy execution #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering when this could get merged? |
Signed-off-by: Marc Romeyn <[email protected]>
Signed-off-by: Marc Romeyn <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Marc Romeyn <[email protected]>
Signed-off-by: Marc Romeyn <[email protected]>
Signed-off-by: Marc Romeyn <[email protected]>
Signed-off-by: Marc Romeyn <[email protected]>
Signed-off-by: Marc Romeyn <[email protected]>
hemildesai
reviewed
Oct 30, 2024
| @@ -253,6 +253,11 @@ def __init__( | |||
| bind_args: bool = True, | |||
| **kwargs, | |||
| ): | |||
| # Handle dict types by converting to _kwargs_to_dict function | |||
| if fn_or_cls is dict or (hasattr(fn_or_cls, "__origin__") and fn_or_cls.__origin__ is dict): | |||
| fn_or_cls = _kwargs_to_dict # type: ignore | |||
There was a problem hiding this comment.
I think you can just set this as dict
| @@ -550,3 +566,7 @@ def _try_set_all(config: _BuildableT, _walk: bool = False, **kwargs) -> _Buildab | |||
| pass | |||
|
|
|||
| return config | |||
|
|
|||
|
|
|||
| def _kwargs_to_dict(**kwargs): | |||
There was a problem hiding this comment.
No need for this if fn_or_cls is set to dict
| @@ -262,6 +267,17 @@ def __init__( | |||
|
|
|||
| super().__init__(fn_or_cls, *args, **new_kwargs) | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
Why is this required? Config object handles dicts.
In [1]: import fiddle as fdl
In [2]: fdl.Config(dict, a=5)
Out[2]: <Config[dict(a=5)]>
In [3]: a = fdl.Config(dict, a=5)
In [4]: fdl.build(a)
Out[4]: {'a': 5}
| @@ -61,6 +61,9 @@ def dryrun_fn( | |||
|
|
|||
|
|
|||
| def direct_run_fn(task: Partial | Script, dryrun: bool = False): | |||
| if hasattr(task, "__is_lazy__"): | |||
There was a problem hiding this comment.
Shouldn't this be is_lazy to be consistent with the others?
| @@ -0,0 +1,93 @@ | |||
| # SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
There was a problem hiding this comment.
This should be moved to the test folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.