Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slurm environment variables for non-het task groups #89

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Fix slurm environment variables for non-het task groups #89

merged 3 commits into from
Oct 23, 2024

Conversation

Kipok
Copy link
Collaborator

@Kipok Kipok commented Oct 23, 2024

There was a bug that when task group was used and heterogeneous is False, the environment variables were ignored in slurm

@Kipok Kipok requested a review from hemildesai October 23, 2024 05:14
@Kipok
Put res group inside if
cdcc355 
Signed-off-by: Igor Gitman <[email protected]>
@Kipok
Update test
7eb0903 
Signed-off-by: Igor Gitman <[email protected]>
hemildesai
hemildesai approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@hemildesai hemildesai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, this method is due for a refactor, but we will tackle the refactor separately.

@Kipok Kipok merged commit 41644dc into NVIDIA:main Oct 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemildesai hemildesai hemildesai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kipok @hemildesai