Enable vortex style fp8 as an option in evo2 #12464
Open
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John St John <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: John St John <[email protected]>
jstjohn
force-pushed
the
jstjohn/evo2-enable-vortex-inference
branch
from
2da79b9 to
5afbbad
Compare
| class _te: | ||
| """If this dummy module is accessed, a not imported error will be raised.""" | ||
|
|
||
| def __getattribute__(self, name: str) -> None: |
Check notice
Code scanning / CodeQL
Non-standard exception raised in special method Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 8 hours ago
To fix the problem, we need to modify the __getattribute__ method to raise an AttributeError instead of an ImportError. This change will ensure that the method conforms to the standard protocol for attribute access in Python. The rest of the functionality should remain the same, and the warning message about the missing transformer_engine module will still be logged.
Suggested changeset
1
nemo/collections/llm/gpt/model/megatron/hyena/hyena_mixer.py
| @@ -62,3 +62,3 @@ | ||
| """Not imported: te. An error will be raised if this is called like a module.""" | ||
| raise ImportError("transformer_engine not installed. Using default recipe.") | ||
| raise AttributeError(f"'_te' object has no attribute '{name}'") | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
hemildesai
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular form of FP8 is needed to replicate a number of results in the Evo2 paper.
PR Type:
Without it we get random AUCs, with it we can recover the results reported in the arc notebooks.