[tripy] Sequential module feature branch #321
Merged
+567
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 29, 2024 21:36
Signed-off-by: Faraz Khoubsirat <[email protected]>
Signed-off-by: Faraz Khoubsirat <[email protected]>
Signed-off-by: Faraz Khoubsirat <[email protected]>
Signed-off-by: Faraz Khoubsirat <[email protected]>
farazkh80
force-pushed
the
tripy-sequential
branch
from
fa98b6b
to
7c6cc5d
Compare
Co-authored-by: pranavm-nvidia <[email protected]> Signed-off-by: Faraz <[email protected]>
Co-authored-by: pranavm-nvidia <[email protected]> Signed-off-by: Faraz <[email protected]>
Co-authored-by: pranavm-nvidia <[email protected]> Signed-off-by: Faraz <[email protected]>
Co-authored-by: pranavm-nvidia <[email protected]> Signed-off-by: Faraz <[email protected]>
Co-authored-by: pranavm-nvidia <[email protected]> Signed-off-by: Faraz <[email protected]>
|
Addressed PR changes, and added some more tests for |
Co-authored-by: pranavm-nvidia <[email protected]> Signed-off-by: Faraz <[email protected]>
|
Addressed final MR change requests and fixed tests @pranavm-nvidia |
pranavm-nvidia
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequential similar to torch.nn.sequential for addressing #295
Things done
tp.Sequentialtests/frontend/module/test_sequential.pySupports nested tp.Sequential and most list operations other than modifications.
tp.Sequentialcan not be modified after creation.