Add basic molecule tests

Author: ajdecon

.yamllint

@@ -0,0 +1,33 @@
+---
+# Based on ansible-lint config
+extends: default
+
+rules:
+  braces:
+    max-spaces-inside: 1
+    level: error
+  brackets:
+    max-spaces-inside: 1
+    level: error
+  colons:
+    max-spaces-after: -1
+    level: error
+  commas:
+    max-spaces-after: -1
+    level: error
+  comments: disable
+  comments-indentation: disable
+  document-start: disable
+  empty-lines:
+    max: 3
+    level: error
+  hyphens:
+    level: error
+  indentation: disable
+  key-duplicates: enable
+  line-length: disable
+  new-line-at-end-of-file: disable
+  new-lines:
+    type: unix
+  trailing-spaces: disable
+  truthy: disable

meta/main.yml

@@ -1,5 +1,6 @@
 galaxy_info:
   role_name: enroot
+  namespace: nvidia
   author: Luke Yeager
   company: NVIDIA
   description: Install enroot
@@ -10,6 +11,7 @@ galaxy_info:
     - name: Ubuntu
       versions:
         - 'bionic'
+        - 'focal'
     - name: EL
       versions:
         - '7'

molecule/default/converge.yml

@@ -0,0 +1,7 @@
+---
+- name: Converge
+  hosts: all
+  tasks:
+    - name: "Include ansible-role-enroot"
+      include_role:
+        name: "ansible-role-enroot"

molecule/default/molecule.yml

@@ -0,0 +1,22 @@
+---
+dependency:
+  name: galaxy
+driver:
+  name: docker
+platforms:
+  - name: ubuntu-1804
+    image: geerlingguy/docker-ubuntu1804-ansible
+    pre_build_image: true
+  - name: ubuntu-2004
+    image: geerlingguy/docker-ubuntu2004-ansible
+    pre_build_image: true
+  - name: centos-7
+    image: geerlingguy/docker-centos7-ansible
+    pre_build_image: true
+  - name: centos-8
+    image: geerlingguy/docker-centos8-ansible
+    pre_build_image: true
+provisioner:
+  name: ansible
+verifier:
+  name: ansible

molecule/default/verify.yml

@@ -0,0 +1,28 @@
+---
+- name: Verify
+  hosts: all
+  tasks:
+  - name: gather package facts
+    package_facts:
+
+  - name: check that enroot is installed
+    assert:
+      that:
+      - "'enroot' in ansible_facts.packages"
+      - "'enroot+caps' in ansible_facts.packages"
+
+  - name: check for path to enroot
+    command: which enroot
+    register: which_enroot
+    changed_when: which_enroot.rc != 0
+
+  - name: verify path to enroot
+    assert:
+      that:
+      - "'/usr/bin/enroot' in which_enroot.stdout"
+
+  - name: check that bash completion is present
+    command: ls /etc/bash_completion.d/enroot.bash_completion
+
+  - name: check that enroot.conf is present
+    command: ls /etc/enroot/enroot.conf

tasks/main.yml

@@ -7,6 +7,14 @@
   include_tasks: redhat.yml
   when: ansible_os_family == 'RedHat'
 
+- name: ensure bash completion dir exists
+  file:
+    path: /etc/bash_completion.d
+    owner: root
+    group: root
+    mode: 755
+    state: directory
+
 - name: install bash completions
   file:
     path: /etc/bash_completion.d/enroot.bash_completion

tasks/redhat.yml

@@ -41,7 +41,7 @@
       state: "absent"
     when:
     - "'enroot' in ansible_facts.packages"
-    - "ansible_facts.packages['enroot'][0]['version'] != enroot_version_string"
+    - "ansible_facts.packages['enroot'][0]['version'] != enroot_version_string.split('-')[0]"
   - name: enroot rpm packages
     yum:
       name: "{{ item }}"
@@ -53,17 +53,23 @@
   shell: "cat /proc/cmdline | grep 'namespace.unpriv_enable=1'"
   register: kernel_unpriv_enable
   failed_when: kernel_unpriv_enable.rc == 127
+  tags:
+  - molecule-notest
 
 - name: check if user namespaces enabled
   shell: "cat /proc/cmdline | grep 'user_namespace.enable=1'"
   register: kernel_user_namespace
   failed_when: kernel_user_namespace.rc == 127
+  tags:
+  - molecule-notest
 
 - name: install grubby if needed
   yum:
     name: "grubby"
     state: "present"
   when: ((kernel_unpriv_enable.rc == 1) or (kernel_user_namespace.rc == 1)) and enroot_configure_kernel_options
+  tags:
+  - molecule-notest
 
 - name: add kernel options to use enroot
   command: "grubby --update-kernel={{ enroot_configure_kernel_options_versions }} --args={{ item }}"
@@ -73,15 +79,22 @@
     - "user_namespace.enable=1"
   notify:
   - reboot node
+  tags:
+  - molecule-notest
 
 - name: set max_user_namespaces 
   sysctl:
     name: user.max_user_namespaces
     value: "{{ enroot_max_user_namespaces }}"
     state: present
+  tags:
+  - molecule-notest
 
 - name: set max_mnt_namespaces
   sysctl:
     name: user.max_mnt_namespaces
     value: "{{ enroot_max_mnt_namespaces }}"
     state: present
+  tags:
+  - molecule-notest
+

tasks/ubuntu.yml

@@ -1,6 +1,7 @@
 ---
 - name: enroot dependency packages
   apt:
+    update_cache: yes
     name:
       - bash-completion
       - pigz
@@ -43,4 +44,4 @@
     name: "{{ enroot_packages }}"
     state: "{{ enroot_package_state }}"
   when: enroot_ubuntu_repo is defined
-  
+