Add automated tests with Molecule #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeyeager
reviewed
Jan 5, 2022
| pre_build_image: true | ||
| - name: centos-7 | ||
| image: geerlingguy/docker-centos7-ansible | ||
| pre_build_image: true |
There was a problem hiding this comment.
Could do centos8 too, right? It's listed in meta/main.yml, at least.
Also minor tweaks to the install process, as the container for CentOS 8 is pickier about GPG key validation than CentOS 7. Note that we disable the GPG check when installing Enroot because the packages on Github are not signed.
|
Added CentOS 8! And confirmed that all tests pass on this branch. 🎉 https://github.com/ajdecon/ansible-role-enroot/runs/4717679877 |
kftsehk
reviewed
Feb 29, 2024
| - name: enroot rpm packages | ||
| yum: | ||
| name: "{{ item }}" | ||
| state: "{{ enroot_package_state }}" | ||
| disable_gpg_check: true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some basic automated tests with Ansible Molecule, as well as a Github action to execute them on push and PR.
Also makes some minor changes to the role to get the tests passing. 😉