-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] operator API revision to align with specs #2710
base: main
Are you sure you want to change the base?
Conversation
…I haven't committed yet Signed-off-by: Bettina Heim <[email protected]>
…n changes I haven't committed yet Signed-off-by: Bettina Heim <[email protected]>
…itted yet Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
…r cleaner and more predictable Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
…_operator.cpp Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
Early cmake changes necessary (?) for libraries
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
Try fixing ObserveAnsatz
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
|
||
namespace cudaq { | ||
|
||
// FIXME: rename to spin ... | ||
class spin_operator : public operator_handler { | ||
enum class pauli { I, X, Y, Z }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a different order than the order called out in the comment on line 27. Does that matter? Should the comment or enum be updated?
// I = 0, Z = 1, X = 2, Y = 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order does not matter, and neither ever does the private op code - it is private for a reason. :)
That said, I can align it with this one so that the data format and the internal representation match.
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Signed-off-by: Bettina Heim <[email protected]>
Command Bot: Processing... |
I still meant to move the operator files into a separate folder. I'll do that last once I've checked everything else looks good.
I'll also take another look to exhaustively list what really needs to be breaking changes, and what can be further mitigated.
Most of the changes are just renaming + updates to the new API to avoid using what will be deprecated. The meaningful changes are: