First shot memory #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmhowe23
added a commit
to bmhowe23/cudaqx
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Ben Howe <[email protected]>
bmhowe23
added a commit
that referenced
this pull request
Feb 19, 2025
This fixes what a bug with #61. The problem was that the first round data in `syndromeTensor` was only being copied for `shot == 0` and was left uninitialized/uncopied for all other shots. Signed-off-by: Ben Howe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the API of
qec::sample_memory_circuitto return nRounds of data as opposed to nRounds - 1 of data. Along with returning nRounds - 1 of xor'd syndrome data, the initial unxor'd shot is also returned first.