Ensure the timestamp be treated as a date-time value, allowing Kubern…

…etes to display it as an "age" based on the time difference (#144) Signed-off-by: Shiva Krishna, Merla <[email protected]>
NVIDIA · Sep 19, 2024 · bf90441 · bf90441
1 parent ae2681e
commit bf90441
Show file tree

Hide file tree

Showing 12 changed files with 30 additions and 21 deletions.
diff --git a/api/apps/v1alpha1/nimcache_types.go b/api/apps/v1alpha1/nimcache_types.go
@@ -223,7 +223,7 @@ func (s *NIMSource) EnvFromSecrets() []v1.EnvFromSource {
 // +kubebuilder:subresource:status
 // +kubebuilder:printcolumn:name="Status",type=string,JSONPath=`.status.state`,priority=0
 // +kubebuilder:printcolumn:name="PVC",type=string,JSONPath=`.status.pvc`,priority=0
-// +kubebuilder:printcolumn:name="Age",type=string,JSONPath=`.metadata.creationTimestamp`,priority=0
+// +kubebuilder:printcolumn:name="Age",type="date",format="date-time",JSONPath=".metadata.creationTimestamp",priority=0
 
 // NIMCache is the Schema for the nimcaches API
 type NIMCache struct {

diff --git a/api/apps/v1alpha1/nimpipeline_types.go b/api/apps/v1alpha1/nimpipeline_types.go
@@ -81,7 +81,7 @@ type NIMPipelineStatus struct {
 // +kubebuilder:object:root=true
 // +kubebuilder:subresource:status
 // +kubebuilder:printcolumn:name="Status",type=string,JSONPath=`.status.state`,priority=0
-// +kubebuilder:printcolumn:name="Age",type=string,JSONPath=`.metadata.creationTimestamp`,priority=0
+// +kubebuilder:printcolumn:name="Age",type="date",format="date-time",JSONPath=".metadata.creationTimestamp",priority=0
 
 // NIMPipeline is the Schema for the nimpipelines API
 type NIMPipeline struct {

diff --git a/api/apps/v1alpha1/nimservice_types.go b/api/apps/v1alpha1/nimservice_types.go
@@ -99,7 +99,7 @@ type NIMServiceStatus struct {
 // +kubebuilder:object:root=true
 // +kubebuilder:subresource:status
 // +kubebuilder:printcolumn:name="Status",type=string,JSONPath=`.status.state`,priority=0
-// +kubebuilder:printcolumn:name="Age",type=string,JSONPath=`.metadata.creationTimestamp`,priority=0
+// +kubebuilder:printcolumn:name="Age",type="date",format="date-time",JSONPath=".metadata.creationTimestamp",priority=0
 
 // NIMService is the Schema for the nimservices API
 type NIMService struct {

diff --git a/bundle/manifests/apps.nvidia.com_nimcaches.yaml b/bundle/manifests/apps.nvidia.com_nimcaches.yaml
@@ -21,9 +21,10 @@ spec:
     - jsonPath: .status.pvc
       name: PVC
       type: string
-    - jsonPath: .metadata.creationTimestamp
+    - format: date-time
+      jsonPath: .metadata.creationTimestamp
       name: Age
-      type: string
+      type: date
     name: v1alpha1
     schema:
       openAPIV3Schema:

diff --git a/bundle/manifests/apps.nvidia.com_nimpipelines.yaml b/bundle/manifests/apps.nvidia.com_nimpipelines.yaml
@@ -18,9 +18,10 @@ spec:
     - jsonPath: .status.state
       name: Status
       type: string
-    - jsonPath: .metadata.creationTimestamp
+    - format: date-time
+      jsonPath: .metadata.creationTimestamp
       name: Age
-      type: string
+      type: date
     name: v1alpha1
     schema:
       openAPIV3Schema:

diff --git a/bundle/manifests/apps.nvidia.com_nimservices.yaml b/bundle/manifests/apps.nvidia.com_nimservices.yaml
@@ -18,9 +18,10 @@ spec:
     - jsonPath: .status.state
       name: Status
       type: string
-    - jsonPath: .metadata.creationTimestamp
+    - format: date-time
+      jsonPath: .metadata.creationTimestamp
       name: Age
-      type: string
+      type: date
     name: v1alpha1
     schema:
       openAPIV3Schema:

diff --git a/config/crd/bases/apps.nvidia.com_nimcaches.yaml b/config/crd/bases/apps.nvidia.com_nimcaches.yaml
@@ -21,9 +21,10 @@ spec:
     - jsonPath: .status.pvc
       name: PVC
       type: string
-    - jsonPath: .metadata.creationTimestamp
+    - format: date-time
+      jsonPath: .metadata.creationTimestamp
       name: Age
-      type: string
+      type: date
     name: v1alpha1
     schema:
       openAPIV3Schema:

diff --git a/config/crd/bases/apps.nvidia.com_nimpipelines.yaml b/config/crd/bases/apps.nvidia.com_nimpipelines.yaml
@@ -18,9 +18,10 @@ spec:
     - jsonPath: .status.state
       name: Status
       type: string
-    - jsonPath: .metadata.creationTimestamp
+    - format: date-time
+      jsonPath: .metadata.creationTimestamp
       name: Age
-      type: string
+      type: date
     name: v1alpha1
     schema:
       openAPIV3Schema:

diff --git a/config/crd/bases/apps.nvidia.com_nimservices.yaml b/config/crd/bases/apps.nvidia.com_nimservices.yaml
@@ -18,9 +18,10 @@ spec:
     - jsonPath: .status.state
       name: Status
       type: string
-    - jsonPath: .metadata.creationTimestamp
+    - format: date-time
+      jsonPath: .metadata.creationTimestamp
       name: Age
-      type: string
+      type: date
     name: v1alpha1
     schema:
       openAPIV3Schema:

diff --git a/deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nimcaches.yaml b/deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nimcaches.yaml
@@ -21,9 +21,10 @@ spec:
     - jsonPath: .status.pvc
       name: PVC
       type: string
-    - jsonPath: .metadata.creationTimestamp
+    - format: date-time
+      jsonPath: .metadata.creationTimestamp
       name: Age
-      type: string
+      type: date
     name: v1alpha1
     schema:
       openAPIV3Schema:

diff --git a/deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nimpipelines.yaml b/deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nimpipelines.yaml
@@ -18,9 +18,10 @@ spec:
     - jsonPath: .status.state
       name: Status
       type: string
-    - jsonPath: .metadata.creationTimestamp
+    - format: date-time
+      jsonPath: .metadata.creationTimestamp
       name: Age
-      type: string
+      type: date
     name: v1alpha1
     schema:
       openAPIV3Schema:

diff --git a/deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nimservices.yaml b/deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nimservices.yaml
@@ -18,9 +18,10 @@ spec:
     - jsonPath: .status.state
       name: Status
       type: string
-    - jsonPath: .metadata.creationTimestamp
+    - format: date-time
+      jsonPath: .metadata.creationTimestamp
       name: Age
-      type: string
+      type: date
     name: v1alpha1
     schema:
       openAPIV3Schema: