Updating nimcache crd to auto detect #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visheshtanksale
requested review from
ArangoGutierrez,
shivamerla and
slu2011
as code owners
slu2011
previously approved these changes
Aug 27, 2024
visheshtanksale
force-pushed
the
nvbug-4800683
branch
from
c30feeb
to
da42586
Compare
shivamerla
reviewed
Aug 28, 2024
|
Is the goal to select model profiles automatically, by default, unless the model profiles are specified? |
Yes, we discussed this, the default is to apply profile selection with given parameters, when these are not selected explicitly. The |
visheshtanksale
force-pushed
the
nvbug-4800683
branch
from
da42586
to
d2f40e9
Compare
Signed-off-by: Vishesh Tanksale <[email protected]>
Signed-off-by: Vishesh Tanksale <[email protected]>
visheshtanksale
force-pushed
the
nvbug-4800683
branch
from
2f7f305
to
573e09f
Compare
Signed-off-by: Vishesh Tanksale <[email protected]>
shivamerla
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.