Remove deprecated rbac proxy container for metrics #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamerla
requested review from
ArangoGutierrez,
slu2011 and
visheshtanksale
as code owners
slu2011
approved these changes
Oct 24, 2024
…e for authn/authz for metrics Reference: https://book.kubebuilder.io/reference/metrics Signed-off-by: Shiva Krishna, Merla <[email protected]>
Signed-off-by: Shiva Krishna, Merla <[email protected]>
shivamerla
force-pushed
the
deprate_rbac_proxy
branch
from
19bf1f0
to
71891cb
Compare
visheshtanksale
pushed a commit
to visheshtanksale/k8s-nim-operator
that referenced
this pull request
Nov 5, 2024
* Deprecate kube-rbac-proxy and use controller-runtimes in-built feature for authn/authz for metrics Reference: https://book.kubebuilder.io/reference/metrics Signed-off-by: Shiva Krishna, Merla <[email protected]> * vendor dependencies Signed-off-by: Shiva Krishna, Merla <[email protected]> --------- Signed-off-by: Shiva Krishna, Merla <[email protected]>
visheshtanksale
pushed a commit
to visheshtanksale/k8s-nim-operator
that referenced
this pull request
Nov 6, 2024
* Deprecate kube-rbac-proxy and use controller-runtimes in-built feature for authn/authz for metrics Reference: https://book.kubebuilder.io/reference/metrics Signed-off-by: Shiva Krishna, Merla <[email protected]> * vendor dependencies Signed-off-by: Shiva Krishna, Merla <[email protected]> --------- Signed-off-by: Shiva Krishna, Merla <[email protected]>
visheshtanksale
pushed a commit
to visheshtanksale/k8s-nim-operator
that referenced
this pull request
Nov 6, 2024
* Deprecate kube-rbac-proxy and use controller-runtimes in-built feature for authn/authz for metrics Reference: https://book.kubebuilder.io/reference/metrics Signed-off-by: Shiva Krishna, Merla <[email protected]> * vendor dependencies Signed-off-by: Shiva Krishna, Merla <[email protected]> --------- Signed-off-by: Shiva Krishna, Merla <[email protected]> Signed-off-by: Vishesh Tanksale <[email protected]>
visheshtanksale
pushed a commit
to visheshtanksale/k8s-nim-operator
that referenced
this pull request
Nov 6, 2024
* Deprecate kube-rbac-proxy and use controller-runtimes in-built feature for authn/authz for metrics Reference: https://book.kubebuilder.io/reference/metrics Signed-off-by: Shiva Krishna, Merla <[email protected]> * vendor dependencies Signed-off-by: Shiva Krishna, Merla <[email protected]> --------- Signed-off-by: Shiva Krishna, Merla <[email protected]> Signed-off-by: Vishesh Tanksale <[email protected]>
visheshtanksale
pushed a commit
to visheshtanksale/k8s-nim-operator
that referenced
this pull request
Nov 6, 2024
* Deprecate kube-rbac-proxy and use controller-runtimes in-built feature for authn/authz for metrics Reference: https://book.kubebuilder.io/reference/metrics Signed-off-by: Shiva Krishna, Merla <[email protected]> * vendor dependencies Signed-off-by: Shiva Krishna, Merla <[email protected]> --------- Signed-off-by: Shiva Krishna, Merla <[email protected]> Signed-off-by: Vishesh Tanksale <[email protected]>
shivamerla
added a commit
that referenced
this pull request
Nov 6, 2024
* Update service type based on the CR spec (#193) Signed-off-by: Shiva Krishna, Merla <[email protected]> Signed-off-by: Vishesh Tanksale <[email protected]> * Allow users to specify runtimeclass name for NIM deployments (#194) * Allow users to specify runtimeclass name for NIM deployments Signed-off-by: Shiva Krishna, Merla <[email protected]> * Avoid runtimeclass name for caching as model can be downloaded on a non-gpu node Signed-off-by: Shiva Krishna, Merla <[email protected]> --------- Signed-off-by: Shiva Krishna, Merla <[email protected]> Signed-off-by: Vishesh Tanksale <[email protected]> * Remove deprecated rbac proxy container for metrics (#192) * Deprecate kube-rbac-proxy and use controller-runtimes in-built feature for authn/authz for metrics Reference: https://book.kubebuilder.io/reference/metrics Signed-off-by: Shiva Krishna, Merla <[email protected]> * vendor dependencies Signed-off-by: Shiva Krishna, Merla <[email protected]> --------- Signed-off-by: Shiva Krishna, Merla <[email protected]> Signed-off-by: Vishesh Tanksale <[email protected]> * Add utility package to detect underlying container orchestrator type (#197) Signed-off-by: Shiva Krishna, Merla <[email protected]> Signed-off-by: Vishesh Tanksale <[email protected]> * Add common metadata required for RedHat certification (#196) Signed-off-by: Shiva Krishna, Merla <[email protected]> Signed-off-by: Vishesh Tanksale <[email protected]> * Refactor custom CA cert injection (#204) Signed-off-by: Shiva Krishna, Merla <[email protected]> Signed-off-by: Vishesh Tanksale <[email protected]> * Allow custom env to be setup for caching jobs (#203) This is useful in following cases * To provide proxy env variables https_proxy etc, for caching * For custom model pullers, these can control the behavior of caching job Signed-off-by: Shiva Krishna, Merla <[email protected]> Signed-off-by: Vishesh Tanksale <[email protected]> * Add orchestrator type specific spec for pods created by the operator (#201) * Add orchestrator type specific spec for pods created by the operator For e.g. seccompprofile is a must for TKGS while not supported on OCP with the nonroot SCC Signed-off-by: Shiva Krishna, Merla <[email protected]> --------- Signed-off-by: Shiva Krishna, Merla <[email protected]> Co-authored-by: Vishesh Tanksale <[email protected]> Signed-off-by: Vishesh Tanksale <[email protected]> * Add Helm pre-upgrade hook for automatic upgrade to latest CRDs (#208) * Add Helm pre-upgrade hook for automatic upgrade to latest CRDs Signed-off-by: Shiva Krishna, Merla <[email protected]> * Add security context for the upgrade hook Signed-off-by: Shiva Krishna, Merla <[email protected]> --------- Signed-off-by: Shiva Krishna, Merla <[email protected]> Signed-off-by: Vishesh Tanksale <[email protected]> * Fix entrypoint for the upgrade hook to avoid invoking shell (#209) Signed-off-by: Shiva Krishna, Merla <[email protected]> Signed-off-by: Vishesh Tanksale <[email protected]> * Removing NGC Home path and HF_HOME env (#202) (#211) Signed-off-by: Vishesh Tanksale <[email protected]> --------- Signed-off-by: Shiva Krishna, Merla <[email protected]> Signed-off-by: Vishesh Tanksale <[email protected]> Co-authored-by: Shiva Krishna Merla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.