Skip to content

Commit

Permalink
Remove pylint since it offers little value over ruff for this project (
Browse files Browse the repository at this point in the history
…#329)

* Disable pylint rules that disagree with ruff

- broad-exception-caught: this is BLE... on ruff
- wrong-import-position: ruff I disagrees with pylint

* Remove pylint instead since it offers little value over ruff for this project
  • Loading branch information
bdraco authored Feb 7, 2025
1 parent 96824e4 commit a52dc80
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 57 deletions.
54 changes: 0 additions & 54 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ version = "0.40.0"

[project.optional-dependencies]
lint = [
"pylint==3.2.7",
"ruff==0.9.5",
]
test = [
Expand Down Expand Up @@ -68,59 +67,6 @@ sections = [
]
use_parentheses = true

[tool.pylint.BASIC]
disable = [
"abstract-method",
"cyclic-import",
"duplicate-code",
"global-statement",
"line-too-long",
"locally-disabled",
"missing-docstring",
"not-context-manager",
"protected-access",
"too-few-public-methods",
"too-few-public-methods",
"too-many-arguments",
"too-many-branches",
"too-many-branches",
"too-many-instance-attributes",
"too-many-lines",
"too-many-locals",
"too-many-locals",
"too-many-public-methods",
"too-many-return-statements",
"too-many-statements",
"unused-argument",
]
generated-members=[
"botocore.errorfactory",
]
good-names= [
"_",
"ex",
"fp",
"i",
"id",
"iv",
"j",
"k",
"Run",
"T",
]


[tool.pylint.EXCEPTIONS]
overgeneral-exceptions=[
"builtins.Exception",
]

[tool.pylint.MAIN]
ignore=[
"tests_*",
]
reports=false

[tool.pytest.ini_options]
asyncio_mode = "auto"

Expand Down
1 change: 0 additions & 1 deletion scripts/lint
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ cd "$(dirname "$0")/.."

python3 -m ruff check --fix snitun
python3 -m ruff format --check snitun
python3 -m pylint snitun
2 changes: 0 additions & 2 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@

logging.basicConfig(level=logging.DEBUG)

# pylint: disable=redefined-outer-name


@attr.s
class Client:
Expand Down

0 comments on commit a52dc80

Please sign in to comment.