This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Backport #2512 to 1.x-WorkingBranch #2616
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emp files if .Dispose() not explicitly called. (NancyFx#2430) # Conflicts: # src/Nancy/IO/RequestStream.cs
Allows swapping out switchover stream behaviour Backport of NancyFx#2512
|
Build failure does not seem related to this PR. |
|
@danbarua Want to rebase this? Just so we can see if it fixes the build. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
^ not covered by tests in this branch
Description
Replaces references to
RequestStreamwith baseStreamso that it can be swapped with another implementation eg. Microsof.IO.RecyclableMemoryStreamThis will allow us to fix our production issues without upgrading to Nancy 2.x and give us some tracing, hopefully we will be able to pin down where the leaking TempFiles issue is coming from.