add support for NanoVNA F V2 for reaching max datapoints up to 201 and 301 on different firmwares #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, 11, 51, 201, 301, 501, 801
…t uppercase SN commands or lowercase sn commands
…feature in new Class NanoVNA_F_V3 rather than modifying the VNA.py
…d 301 on different firmwares
This was referenced Jan 19, 2025
|
Are you able to refactor your code contributions? |
It looks the root code base have fully refactored after my pull-request. When I made the pull-request, the code base was okay and working. I will have a look when I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #691
What is the new behavior?
max datapoints on NanoVNA F V2 can reach up to 301 starting from firmware 0.5.0 and onwards.
max datapoints on NanoVNA F V2 can reach up to 201 starting from firmware 0.2.0 and onwards.
Recommend NanoVNA F V2 owners to upgrade their firmware higher or equally than version 0.5.0.
Does this introduce a breaking change?
Other information