Skip to content

Commit 83eb060

Browse files
Merge pull request #23 from NeowayLabs/fix-is-valid-message-merge-master
fix: Fix IsValidMessage method adding a new exception for merge from master to the branch
2 parents 247ac03 + abfdc33 commit 83eb060

File tree

3 files changed

+26
-1
lines changed

3 files changed

+26
-1
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
v2.0.3:
2+
- Fix IsValidMessage method adding a new exception for merge from master to the branch (@esequiel.virtuoso)
3+
14
v2.0.2:
25
- Fix IsValidMessage method adding a new exception for merge from master to the branch (@esequiel.virtuoso)
36

src/commit-message/commit_message_manager.go

+7-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,13 @@ func isMergeMasterToBranch(message string) bool {
7979
splitedMessage := strings.Split(strings.ToLower(message), "\n")
8080

8181
for _, row := range splitedMessage {
82-
if strings.Contains(row, "'origin/master' into") || strings.Contains(row, "merge branch 'master' into") {
82+
lowerRow := strings.ToLower(row)
83+
if strings.Contains(lowerRow, "'origin/master' into") ||
84+
strings.Contains(lowerRow, "merge branch 'master' into") ||
85+
strings.Contains(lowerRow, "merge branch 'master' of") ||
86+
strings.Contains(lowerRow, "'origin/main' into") ||
87+
strings.Contains(lowerRow, "merge branch 'main' into") ||
88+
strings.Contains(lowerRow, "merge branch 'main' of") {
8389
return true
8490
}
8591
}

src/commit-message/commit_message_manager_test.go

+16
Original file line numberDiff line numberDiff line change
@@ -104,4 +104,20 @@ func TestIsValidMessageMergeMasterBranchSuccess(t *testing.T) {
104104
message = "first message row \n Merge branch 'master' into something \n last message row"
105105
actual = f.commitMessageManager.IsValidMessage(message)
106106
tests.AssertTrue(t, actual)
107+
108+
message = "first message row \n Merge branch 'master' of something \n last message row"
109+
actual = f.commitMessageManager.IsValidMessage(message)
110+
tests.AssertTrue(t, actual)
111+
112+
message = "first message row \n Merge remote-tracking branch 'origin/main' into something \n last message row"
113+
actual = f.commitMessageManager.IsValidMessage(message)
114+
tests.AssertTrue(t, actual)
115+
116+
message = "first message row \n Merge branch 'main' into something \n last message row"
117+
actual = f.commitMessageManager.IsValidMessage(message)
118+
tests.AssertTrue(t, actual)
119+
120+
message = "first message row \n Merge branch 'main' of something \n last message row"
121+
actual = f.commitMessageManager.IsValidMessage(message)
122+
tests.AssertTrue(t, actual)
107123
}

0 commit comments

Comments
 (0)