Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: [feat], message: Add commit lint option. #18

Merged
merged 25 commits into from
Mar 5, 2024

Conversation

esequielvirtuoso
Copy link
Collaborator

What?

type: [feat], message: Add commit lint option.

Type of change?

  • [feat]: A new feature

Note: Remove the non-checked options

Why?

Here you express the reason it is necessary (keep the so what? factor in mind)

How?

Here you give a little more detail on the implementation or justify any unorthodox choice or practice.

How has this been tested?

  • Unit tests

Before submitting a PR please make sure to check if:

  • The code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and/or existing unit tests pass locally with my changes
  • New and/or existing integration tests pass locally with my changes

Copy link
Collaborator

@julianogalgaro julianogalgaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Collaborator

@ebbauer ebbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some files have different naming pattern than others

Copy link
Collaborator

@julianogalgaro julianogalgaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, but maybe we need to update the mr description with the new pattern.

@esequielvirtuoso esequielvirtuoso merged commit 4c031f7 into main Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants