Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [taro-mini-runner]微信小程序tabbar list 中数据类型不匹配时编译时需报错提醒 #15941

Closed
wants to merge 2 commits into from

Conversation

xujiujiu
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)

编译成小程序时,若tabbar 的list中存在数据类型不匹配的情况,编译时需做报错提醒。当前情况只会报错:Cannot read properties of null (reading 'iconPath')

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.50%. Comparing base (a8ac196) to head (28b39aa).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15941      +/-   ##
==========================================
- Coverage   56.51%   56.50%   -0.01%     
==========================================
  Files         500      500              
  Lines       22767    22773       +6     
  Branches     5750     5600     -150     
==========================================
+ Hits        12866    12869       +3     
- Misses       8696     8824     +128     
+ Partials     1205     1080     -125     
Flag Coverage Δ
taro-cli 75.00% <ø> (ø)
taro-runner 57.46% <57.14%> (+3.45%) ⬆️
taro-runtime 79.39% <ø> (ø)
taro-web 40.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ackages/taro-mini-runner/src/plugins/MiniPlugin.ts 69.76% <57.14%> (-0.20%) ⬇️

... and 41 files with indirect coverage changes

This was referenced Jun 22, 2024
This was referenced Jul 6, 2024
@liqinuo liqinuo changed the base branch from main to 3.x July 16, 2024 06:50
@ZEJIA-LIU ZEJIA-LIU deleted the branch NervJS:main July 16, 2024 07:16
@ZEJIA-LIU ZEJIA-LIU closed this Jul 16, 2024
@ZEJIA-LIU ZEJIA-LIU reopened this Jul 16, 2024
@xujiujiu xujiujiu changed the base branch from 3.x to main July 30, 2024 06:57
@xujiujiu
Copy link
Contributor Author

xujiujiu commented Jul 30, 2024

#16225 中跟踪

@xujiujiu xujiujiu closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants